Skip to content

Commit 2ac77aa

Browse files
authored
Clean up vestige of useOpaqueIdentifier (#25587)
Found some code that was left over from the experimental useOpaqueIdentifier hook, which we eventually replaced with useId. This deletes it.
1 parent bdd3d08 commit 2ac77aa

File tree

4 files changed

+2
-28
lines changed

4 files changed

+2
-28
lines changed

packages/react-reconciler/src/ReactFiberHooks.new.js

-9
Original file line numberDiff line numberDiff line change
@@ -767,8 +767,6 @@ export function resetHooksAfterThrow(): void {
767767
hookTypesUpdateIndexDev = -1;
768768

769769
currentHookNameInDev = null;
770-
771-
isUpdatingOpaqueValueInRenderPhase = false;
772770
}
773771

774772
didScheduleRenderPhaseUpdateDuringThisPass = false;
@@ -2380,13 +2378,6 @@ function rerenderTransition(): [
23802378
return [isPending, start];
23812379
}
23822380

2383-
let isUpdatingOpaqueValueInRenderPhase = false;
2384-
export function getIsUpdatingOpaqueValueInRenderPhaseInDEV(): boolean | void {
2385-
if (__DEV__) {
2386-
return isUpdatingOpaqueValueInRenderPhase;
2387-
}
2388-
}
2389-
23902381
function mountId(): string {
23912382
const hook = mountWorkInProgressHook();
23922383

packages/react-reconciler/src/ReactFiberHooks.old.js

-9
Original file line numberDiff line numberDiff line change
@@ -767,8 +767,6 @@ export function resetHooksAfterThrow(): void {
767767
hookTypesUpdateIndexDev = -1;
768768

769769
currentHookNameInDev = null;
770-
771-
isUpdatingOpaqueValueInRenderPhase = false;
772770
}
773771

774772
didScheduleRenderPhaseUpdateDuringThisPass = false;
@@ -2380,13 +2378,6 @@ function rerenderTransition(): [
23802378
return [isPending, start];
23812379
}
23822380

2383-
let isUpdatingOpaqueValueInRenderPhase = false;
2384-
export function getIsUpdatingOpaqueValueInRenderPhaseInDEV(): boolean | void {
2385-
if (__DEV__) {
2386-
return isUpdatingOpaqueValueInRenderPhase;
2387-
}
2388-
}
2389-
23902381
function mountId(): string {
23912382
const hook = mountWorkInProgressHook();
23922383

packages/react-reconciler/src/ReactFiberWorkLoop.new.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,6 @@ import {resetContextDependencies} from './ReactFiberNewContext.new';
205205
import {
206206
resetHooksAfterThrow,
207207
ContextOnlyDispatcher,
208-
getIsUpdatingOpaqueValueInRenderPhaseInDEV,
209208
} from './ReactFiberHooks.new';
210209
import {DefaultCacheDispatcher} from './ReactFiberCache.new';
211210
import {
@@ -3638,10 +3637,7 @@ if (__DEV__) {
36383637

36393638
function warnAboutRenderPhaseUpdatesInDEV(fiber) {
36403639
if (__DEV__) {
3641-
if (
3642-
ReactCurrentDebugFiberIsRenderingInDEV &&
3643-
!getIsUpdatingOpaqueValueInRenderPhaseInDEV()
3644-
) {
3640+
if (ReactCurrentDebugFiberIsRenderingInDEV) {
36453641
switch (fiber.tag) {
36463642
case FunctionComponent:
36473643
case ForwardRef:

packages/react-reconciler/src/ReactFiberWorkLoop.old.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,6 @@ import {resetContextDependencies} from './ReactFiberNewContext.old';
205205
import {
206206
resetHooksAfterThrow,
207207
ContextOnlyDispatcher,
208-
getIsUpdatingOpaqueValueInRenderPhaseInDEV,
209208
} from './ReactFiberHooks.old';
210209
import {DefaultCacheDispatcher} from './ReactFiberCache.old';
211210
import {
@@ -3638,10 +3637,7 @@ if (__DEV__) {
36383637

36393638
function warnAboutRenderPhaseUpdatesInDEV(fiber) {
36403639
if (__DEV__) {
3641-
if (
3642-
ReactCurrentDebugFiberIsRenderingInDEV &&
3643-
!getIsUpdatingOpaqueValueInRenderPhaseInDEV()
3644-
) {
3640+
if (ReactCurrentDebugFiberIsRenderingInDEV) {
36453641
switch (fiber.tag) {
36463642
case FunctionComponent:
36473643
case ForwardRef:

0 commit comments

Comments
 (0)