Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 5198bda

Browse files
committedFeb 27, 2024··
Add disableStringRefs feature flag
1 parent 3bcd2de commit 5198bda

7 files changed

+10
-0
lines changed
 

‎packages/shared/ReactFeatureFlags.js

+1
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ export const enableInfiniteRenderLoopDetection = true;
188188
// Passes `ref` as a normal prop instead of stripping it from the props object
189189
// during element creation.
190190
export const enableRefAsProp = __NEXT_MAJOR__;
191+
export const disableStringRefs = __NEXT_MAJOR__;
191192

192193
// Not ready to break experimental yet.
193194
// Needs more internal cleanup

‎packages/shared/forks/ReactFeatureFlags.native-fb.js

+1
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ export const enableInfiniteRenderLoopDetection = false;
101101
// TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
102102
// because JSX is an extremely hot path.
103103
export const enableRefAsProp = false;
104+
export const disableStringRefs = false;
104105

105106
export const enableReactTestRendererWarning = false;
106107

‎packages/shared/forks/ReactFeatureFlags.native-oss.js

+1
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ export const enableServerComponentLogs = true;
9292

9393
// TODO: Should turn this on in next "major" RN release.
9494
export const enableRefAsProp = false;
95+
export const disableStringRefs = false;
9596

9697
export const enableReactTestRendererWarning = false;
9798

‎packages/shared/forks/ReactFeatureFlags.test-renderer.js

+1
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ export const enableInfiniteRenderLoopDetection = false;
9898
// flags should be handled by the Fiber config.
9999
const __NEXT_MAJOR__ = __EXPERIMENTAL__;
100100
export const enableRefAsProp = __NEXT_MAJOR__;
101+
export const disableStringRefs = __NEXT_MAJOR__;
101102
export const enableReactTestRendererWarning = false;
102103
export const enableBigIntSupport = __NEXT_MAJOR__;
103104

‎packages/shared/forks/ReactFeatureFlags.test-renderer.native.js

+1
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ export const enableServerComponentKeys = true;
8888
export const enableServerComponentLogs = true;
8989

9090
export const enableRefAsProp = false;
91+
export const disableStringRefs = false;
9192

9293
export const enableReactTestRendererWarning = false;
9394

‎packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

+1
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ export const enableServerComponentLogs = true;
9191
export const enableInfiniteRenderLoopDetection = false;
9292

9393
export const enableRefAsProp = false;
94+
export const disableStringRefs = false;
9495

9596
export const enableReactTestRendererWarning = false;
9697

‎packages/shared/forks/ReactFeatureFlags.www.js

+4
Original file line numberDiff line numberDiff line change
@@ -121,5 +121,9 @@ export const enableReactTestRendererWarning = false;
121121

122122
export const enableBigIntSupport = false;
123123

124+
// TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
125+
// because JSX is an extremely hot path.
126+
export const disableStringRefs = false;
127+
124128
// Flow magic to verify the exports of this file match the original version.
125129
((((null: any): ExportsType): FeatureFlagsType): ExportsType);

0 commit comments

Comments
 (0)