Skip to content

Commit 577f2de

Browse files
enableCacheElement flag (#24131)
* enableCacheElement flag * Update packages/shared/forks/ReactFeatureFlags.testing.js Co-authored-by: Ricky <rickhanlonii@gmail.com> * Update packages/shared/forks/ReactFeatureFlags.test-renderer.js Co-authored-by: Ricky <rickhanlonii@gmail.com> * Update packages/shared/forks/ReactFeatureFlags.native-oss.js Co-authored-by: Ricky <rickhanlonii@gmail.com> * Update packages/shared/ReactFeatureFlags.js Co-authored-by: Ricky <rickhanlonii@gmail.com> Co-authored-by: Dave McCabe <davemccabe@fb.com> Co-authored-by: Ricky <rickhanlonii@gmail.com>
1 parent 2e0d86d commit 577f2de

10 files changed

+11
-2
lines changed

packages/shared/ReactFeatureFlags.js

+1
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,7 @@ export const enableLegacyFBSupport = false;
9696
// -----------------------------------------------------------------------------
9797

9898
export const enableCache = __EXPERIMENTAL__;
99+
export const enableCacheElement = __EXPERIMENTAL__;
99100

100101
export const enableTransitionTracing = false;
101102

packages/shared/forks/ReactFeatureFlags.native-fb.js

+1
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ export const enableSuspenseServerRenderer = false;
3030
export const enableSelectiveHydration = false;
3131
export const enableLazyElements = false;
3232
export const enableCache = false;
33+
export const enableCacheElement = true;
3334
export const enableSchedulerDebugging = false;
3435
export const debugRenderPhaseSideEffectsForStrictMode = true;
3536
export const disableJavaScriptURLs = false;

packages/shared/forks/ReactFeatureFlags.native-oss.js

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export const enableSuspenseServerRenderer = false;
2424
export const enableSelectiveHydration = false;
2525
export const enableLazyElements = false;
2626
export const enableCache = false;
27+
export const enableCacheElement = false;
2728
export const disableJavaScriptURLs = false;
2829
export const disableCommentsAsDOMContainers = true;
2930
export const disableInputAttributeSyncing = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.js

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export const enableSuspenseServerRenderer = false;
2424
export const enableSelectiveHydration = false;
2525
export const enableLazyElements = false;
2626
export const enableCache = __EXPERIMENTAL__;
27+
export const enableCacheElement = __EXPERIMENTAL__;
2728
export const disableJavaScriptURLs = false;
2829
export const disableCommentsAsDOMContainers = true;
2930
export const disableInputAttributeSyncing = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.native.js

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export const enableSuspenseServerRenderer = false;
2424
export const enableSelectiveHydration = false;
2525
export const enableLazyElements = false;
2626
export const enableCache = true;
27+
export const enableCacheElement = true;
2728
export const disableJavaScriptURLs = false;
2829
export const disableCommentsAsDOMContainers = true;
2930
export const disableInputAttributeSyncing = false;

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export const enableSuspenseServerRenderer = false;
2424
export const enableSelectiveHydration = false;
2525
export const enableLazyElements = false;
2626
export const enableCache = true;
27+
export const enableCacheElement = true;
2728
export const enableSchedulerDebugging = false;
2829
export const disableJavaScriptURLs = false;
2930
export const disableCommentsAsDOMContainers = true;

packages/shared/forks/ReactFeatureFlags.testing.js

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export const enableSuspenseServerRenderer = false;
2424
export const enableSelectiveHydration = false;
2525
export const enableLazyElements = false;
2626
export const enableCache = __EXPERIMENTAL__;
27+
export const enableCacheElement = __EXPERIMENTAL__;
2728
export const disableJavaScriptURLs = false;
2829
export const disableCommentsAsDOMContainers = true;
2930
export const disableInputAttributeSyncing = false;

packages/shared/forks/ReactFeatureFlags.testing.www.js

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ export const enableSuspenseServerRenderer = true;
2424
export const enableSelectiveHydration = true;
2525
export const enableLazyElements = false;
2626
export const enableCache = true;
27+
export const enableCacheElement = true;
2728
export const disableJavaScriptURLs = true;
2829
export const disableCommentsAsDOMContainers = true;
2930
export const disableInputAttributeSyncing = false;

packages/shared/forks/ReactFeatureFlags.www.js

+1
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ export const enableSelectiveHydration = true;
7272

7373
export const enableLazyElements = true;
7474
export const enableCache = true;
75+
export const enableCacheElement = true;
7576

7677
export const disableJavaScriptURLs = true;
7778

packages/shared/isValidElementType.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import {
2727
} from 'shared/ReactSymbols';
2828
import {
2929
enableScopeAPI,
30-
enableCache,
30+
enableCacheElement,
3131
enableTransitionTracing,
3232
enableDebugTracing,
3333
enableLegacyHidden,
@@ -51,7 +51,7 @@ export default function isValidElementType(type: mixed) {
5151
(enableLegacyHidden && type === REACT_LEGACY_HIDDEN_TYPE) ||
5252
type === REACT_OFFSCREEN_TYPE ||
5353
(enableScopeAPI && type === REACT_SCOPE_TYPE) ||
54-
(enableCache && type === REACT_CACHE_TYPE) ||
54+
(enableCacheElement && type === REACT_CACHE_TYPE) ||
5555
(enableTransitionTracing && type === REACT_TRACING_MARKER_TYPE)
5656
) {
5757
return true;

0 commit comments

Comments
 (0)