Skip to content

Commit 8d820b6

Browse files
committed
chore: use versioned render in editing test
1 parent e51cda5 commit 8d820b6

File tree

1 file changed

+8
-16
lines changed

1 file changed

+8
-16
lines changed

packages/react-devtools-shared/src/__tests__/editing-test.js

+8-16
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,12 @@
1010
import type {FrontendBridge} from 'react-devtools-shared/src/bridge';
1111
import type Store from 'react-devtools-shared/src/devtools/store';
1212

13+
import {getVersionedRenderImplementation} from './utils';
14+
1315
describe('editing interface', () => {
1416
let PropTypes;
1517
let React;
1618
let bridge: FrontendBridge;
17-
let legacyRender;
1819
let store: Store;
1920
let utils;
2021

@@ -25,8 +26,6 @@ describe('editing interface', () => {
2526
beforeEach(() => {
2627
utils = require('./utils');
2728

28-
legacyRender = utils.legacyRender;
29-
3029
bridge = global.bridge;
3130
store = global.store;
3231
store.collapseNodesByDefault = false;
@@ -36,6 +35,8 @@ describe('editing interface', () => {
3635
React = require('react');
3736
});
3837

38+
const {render} = getVersionedRenderImplementation();
39+
3940
describe('props', () => {
4041
let committedClassProps;
4142
let committedFunctionProps;
@@ -66,9 +67,8 @@ describe('editing interface', () => {
6667

6768
inputRef = React.createRef(null);
6869

69-
const container = document.createElement('div');
7070
await utils.actAsync(() =>
71-
legacyRender(
71+
render(
7272
<>
7373
<ClassComponent
7474
array={[1, 2, 3]}
@@ -84,7 +84,6 @@ describe('editing interface', () => {
8484
,
8585
<input ref={inputRef} onChange={jest.fn()} value="initial" />
8686
</>,
87-
container,
8887
),
8988
);
9089

@@ -440,11 +439,9 @@ describe('editing interface', () => {
440439
}
441440
}
442441

443-
const container = document.createElement('div');
444442
await utils.actAsync(() =>
445-
legacyRender(
443+
render(
446444
<ClassComponent object={{nested: 'initial'}} shallow="initial" />,
447-
container,
448445
),
449446
);
450447

@@ -662,10 +659,7 @@ describe('editing interface', () => {
662659
return null;
663660
}
664661

665-
const container = document.createElement('div');
666-
await utils.actAsync(() =>
667-
legacyRender(<FunctionComponent />, container),
668-
);
662+
await utils.actAsync(() => render(<FunctionComponent />));
669663

670664
hookID = 0; // index
671665
id = ((store.getElementIDAtIndex(0): any): number);
@@ -917,13 +911,11 @@ describe('editing interface', () => {
917911
}
918912
}
919913

920-
const container = document.createElement('div');
921914
await utils.actAsync(() =>
922-
legacyRender(
915+
render(
923916
<LegacyContextProvider>
924917
<ClassComponent />
925918
</LegacyContextProvider>,
926-
container,
927919
),
928920
);
929921

0 commit comments

Comments
 (0)