Use invariant() instead

Author: gaearon

packages/react-dom/src/__tests__/ReactDOM-test.js

@@ -373,7 +373,7 @@ describe('ReactDOM', () => {
     }
   });
 
-  it('warns in DEV if jsdom is destroyed by the time setState() is called', () => {
+  it('throws in DEV if jsdom is destroyed by the time setState() is called', () => {
     spyOnDev(console, 'error');
     class App extends React.Component {
       state = {x: 1};
@@ -394,9 +394,7 @@ describe('ReactDOM', () => {
       delete global.document;
       const fn = () => instance.setState({x: 2});
       if (__DEV__) {
-        expect(fn).toThrow('document is not defined');
-        expect(console.error.calls.count()).toBe(1);
-        expect(console.error.calls.argsFor(0)[0]).toContain(
+        expect(fn).toThrow(
           'The `document` global was defined when React was initialized, but is not ' +
             'defined anymore. This can happen in a test environment if a component ' +
             'schedules an update from an asynchronous callback, but the test has already ' +

packages/shared/ReactErrorUtils.js

@@ -8,7 +8,6 @@
  */
 
 import invariant from 'fbjs/lib/invariant';
-import warning from 'fbjs/lib/warning';
 
 const ReactErrorUtils = {
   // Used by Fiber to simulate a try-catch.
@@ -168,9 +167,11 @@ if (__DEV__) {
       e,
       f,
     ) {
-      // If document doesn't exist we know for sure we will crash in this method later.
-      // So we show a warning explaining a potential cause.
-      warning(
+      // If document doesn't exist we know for sure we will crash in this method
+      // when we call document.createEvent(). However this can cause confusing
+      // errors: https://github.com/facebookincubator/create-react-app/issues/3482
+      // So we preemptively throw with a better message instead.
+      invariant(
         typeof document !== 'undefined',
         'The `document` global was defined when React was initialized, but is not ' +
           'defined anymore. This can happen in a test environment if a component ' +