Skip to content

Commit 7bd909b

Browse files
authored
url: set formatUrl method as no side effect
PR-URL: nodejs#46884 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 0abe5ec commit 7bd909b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/node_url.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ void Initialize(Local<Object> target,
313313
void* priv) {
314314
SetMethod(context, target, "parse", Parse);
315315
SetMethod(context, target, "updateUrl", UpdateUrl);
316-
SetMethod(context, target, "formatUrl", FormatUrl);
316+
SetMethodNoSideEffect(context, target, "formatUrl", FormatUrl);
317317

318318
SetMethodNoSideEffect(context, target, "domainToASCII", DomainToASCII);
319319
SetMethodNoSideEffect(context, target, "domainToUnicode", DomainToUnicode);

0 commit comments

Comments
 (0)