Skip to content

Commit d575372

Browse files
maodahuaredhatHameed
authored andcommittedMar 17, 2025·
feat: helm support more deployment config
Signed-off-by: maodahua <maodahua@outlook.com>
1 parent e47a193 commit d575372

File tree

3 files changed

+24
-3
lines changed

3 files changed

+24
-3
lines changed
 

‎infra/charts/feast-feature-server/README.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ See [here](https://github.com/feast-dev/feast/tree/master/examples/python-helm-d
3535
| Key | Type | Default | Description |
3636
|-----|------|---------|-------------|
3737
| affinity | object | `{}` | |
38+
| extraEnvs | list | `[]` | Additional environment variables to be set in the container |
3839
| feast_mode | string | `"online"` | Feast supported deployment modes - online (default), offline, ui and registry |
3940
| feature_store_yaml_base64 | string | `""` | [required] a base64 encoded version of feature_store.yaml |
4041
| fullnameOverride | string | `""` | |
@@ -61,4 +62,6 @@ See [here](https://github.com/feast-dev/feast/tree/master/examples/python-helm-d
6162
| service.port | int | `80` | |
6263
| service.type | string | `"ClusterIP"` | |
6364
| serviceAccount.name | string | `""` | |
64-
| tolerations | list | `[]` | |
65+
| tolerations | list | `[]` | |
66+
| volumeMounts | list | `[]` | |
67+
| volumes | list | `[]` | |

‎infra/charts/feast-feature-server/templates/deployment.yaml

+12-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ spec:
2828
{{- end }}
2929
securityContext:
3030
{{- toYaml .Values.podSecurityContext | nindent 8 }}
31+
{{- with .Values.volumes }}
32+
volumes:
33+
{{- toYaml . | nindent 8 }}
34+
{{- end }}
3135
containers:
3236
- name: {{ .Chart.Name }}
3337
securityContext:
@@ -39,6 +43,9 @@ spec:
3943
value: {{ .Values.feature_store_yaml_base64 }}
4044
- name: INTRA_COMMUNICATION_BASE64
4145
value: {{ "intra-server-communication" | b64enc }}
46+
{{- with .Values.extraEnvs}}
47+
{{- toYaml . | nindent 12 }}
48+
{{- end}}
4249
command:
4350
{{- if eq .Values.feast_mode "offline" }}
4451
- "feast"
@@ -99,6 +106,10 @@ spec:
99106
periodSeconds: {{ .Values.readinessProbe.periodSeconds }}
100107
resources:
101108
{{- toYaml .Values.resources | nindent 12 }}
109+
{{- with .Values.volumeMounts}}
110+
volumeMounts:
111+
{{- toYaml . | nindent 12 }}
112+
{{- end }}
102113
{{- with .Values.nodeSelector }}
103114
nodeSelector:
104115
{{- toYaml . | nindent 8 }}
@@ -110,4 +121,4 @@ spec:
110121
{{- with .Values.tolerations }}
111122
tolerations:
112123
{{- toYaml . | nindent 8 }}
113-
{{- end }}
124+
{{- end }}

‎infra/charts/feast-feature-server/values.yaml

+8-1
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,13 @@ readinessProbe:
7575
initialDelaySeconds: 20
7676
periodSeconds: 10
7777

78+
volumeMounts: []
79+
80+
# extraEnvs -- Additional environment variables to be set in the container
81+
extraEnvs: []
82+
83+
volumes: []
84+
7885
# to create OpenShift Route object for UI
7986
route:
80-
enabled: false
87+
enabled: false

0 commit comments

Comments
 (0)
Please sign in to comment.