Skip to content

Commit ccab7d1

Browse files
committed
deps: cherry-pick cc55747 from V8 upstream
This fixes the flaky message/console test on our CI. Original commit message: [test/message] Allow numbers to have more than one leading digit. The {NUMBER} regexp only allowed one, leading to occasional test failures such as: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/17156 Bug: Change-Id: I25a08b80640d9af19ba70c61c846163685f1cb82 Reviewed-on: https://chromium-review.googlesource.com/753322 Reviewed-by: Franziska Hinkelmann <franzih@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#49109} PR-URL: nodejs#16890 Ref: nodejs/build#936 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 7af469a commit ccab7d1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
# Reset this number to 0 on major V8 upgrades.
2929
# Increment by one for each non-official patch applied to deps/v8.
30-
'v8_embedder_string': '-node.9',
30+
'v8_embedder_string': '-node.10',
3131

3232
# Enable disassembler for `--print-code` v8 options
3333
'v8_enable_disassembler': 1,

deps/v8/test/message/testcfg.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def IsFailureOutput(self, testcase):
107107
expected_lines, actual_lines, fillvalue=''):
108108
pattern = re.escape(expected.rstrip() % env)
109109
pattern = pattern.replace("\\*", ".*")
110-
pattern = pattern.replace("\\{NUMBER\\}", "\d(?:\.\d*)?")
110+
pattern = pattern.replace("\\{NUMBER\\}", "\d+(?:\.\d*)?")
111111
pattern = "^%s$" % pattern
112112
if not re.match(pattern, actual):
113113
return True

0 commit comments

Comments
 (0)