-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIP Discussion: Lightweight Sector Updates #131
Comments
FIP proposal see: https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0017.md |
Note on the current proposal Indeed, in order to perform an update we need SectorKey (that is, the last layer of the SDR graph). For sectors which are not natively CC (meaning, they were created with deals since the beginning) we do not have SectorKey committed onchain (since Replica is different from SectorKey here). Feature Prioritization
Note that, unless there is a change of direction,
Timeline cc @nicola |
The current plan is best. For the current state of the network feature (1) is by far the most useful. Data stored in deals is currently at ~22 PiB vs > 8 EiB of total data growing at > 40 PiB a day. In my opinion we should only work on (2) and (3) once network conditions have changed significantly. |
Agreed - focusing this improvement on CCSectors only (not sectors with deals that have been added to the network already) is a reasonable simplification that brings 99% of the benefit of this change without creating more work. It makes the 8EiB of capacity already added to the network much more accessible for active deal-making, and the (relatively) small number of existing deal sectors will likely expire off the network in the next 6-12 months anyway (at which point they can be replaced with new updateable sector deals). |
Will the replica update proof take similar verification time to PoRep? From what we've learned over the past year we should enable batching wherever possible in miner proving methods. Unless proof verification is much less expensive I'm thinking it could be worth it to implement this with snark pack from the start. |
We will need a circuit to check the replica update was done correctly. Verification should be the usual snark verification. I guess there is no reason for not using snarkpack (i guess you mean snarkpacking different replica update proofs together right?) |
As a miner I am personally very excited about fip 0017 and think it will be a major improvement on the current CC upgrade pathway. I am extremely motivated by the long term vision of the network and very much dislike sealing "junk" data in empty CC sectors. I know many MinerX fellows who feel the same way. It is also very useful in managing sealing costs by creating CC sectors when the base fee is low and then using the upgrade feature exclusively to seal new deal sectors in the empty CC's. The new batching feature has also really helped with this in conjunction with the upgrade feature. Whilst the current CC upgrade pathway works it is not particularly user friendly. The UX is confusing when it comes to displaying the correct upgrade status and the upgrades do not persist across miner restarts. As MinerX fellows we restart A LOT!! I currently use an Excel spreadsheet to manage my upgrades so the bulk of my planning is done outside of Lotus. The new lightweight CC upgrades would hopefully eliminate most of the current issues whilst using some of the existing network capacity to store real data which is ultimately the goal of many of us here. https://filecoinproject.slack.com/archives/C022ZR4JA1M/p1628265181186200 |
I would very much like to see non CC sectors that already contain deals included in this FIP. The flow of deal proposals can be extremely sporadic and as a result there are many occasions when miners are forced to seal almost empty sectors due to time limiting factors such as deal start epoch and PC1 ticket expiry. We therefore end up with multiple 32GiB/64GiB that contain very small individual deals and a large quantity of wasted space. I personally have many sectors that only contain one single 256MiB deal. I believe that the deal flow will continue to be sporadic going forward and that the time limiting factors will remain in place. I would therefore sincerely welcome this addition. Many thanks!! |
The reason for which we do not address sectors that are not natively CC is purely technical: as you can see, one need to have the last layer of the SDR graph in order to perform the data retireval (SectorKey in the FIP proposal). This was in essence the motivation to my first comment above. In the future, we'll explore the possibility of updating non natively CC sectors as well. |
This proposal (and associated FIP-0017 draft) will soon be deferred. The upcoming FIP-0019 will provide a better solution to the problem of CC re-sealing times. For more information, or to contribute to this topic, please see #145 |
Discussion issue for this FIP-0017
Since 90+% of sectors in the Filecoin Network are CC sectors, having a protocol that allows for updating CC sectors to store real data without incurring in a full re-sealing would massively improve our network in terms of the amount of real data stored through it.
The text was updated successfully, but these errors were encountered: