eth_feeHistory should take float64 for rewardPercentiles to be compatible with developer tooling #1137
Closed
8 of 18 tasks
Labels
Milestone
Checklist
Latest release
, or the most recent RC(release canadiate) for the upcoming release or the dev branch(master), or have an issue updating to any of these.Lotus component
Lotus Version
Describe the Bug
Trying to deploy smart contracts to Wallaby using Foundry /
forge script
. Foundry makes aneth_feeHistory
call to the RPC, which fails because of a parameter type mismatch between lotus ETH JSON-RPC and Geth, e.g.Relevant source code:
Lotus: https://github.com/filecoin-project/lotus/blob/release/fevm-wallaby/node/impl/full/eth.go#L421
Geth: https://github.com/ethereum/go-ethereum/blob/master/ethclient/ethclient.go#L516
Logging Information
Repo Steps
How to reproduce:
PRIVATE_KEY="wallaby-private-key"
make testnet_deploy
, which tries to deploy the SampleContract to wallaby and failsThe text was updated successfully, but these errors were encountered: