Skip to content

Commit 936433b

Browse files
committed
Oracle and SQL Server test adjustments
* Split app DeploymentCollectionResourceTest to test sorting and querying separately * Make sure that surefire reports are uploaded with unique names
1 parent f70f947 commit 936433b

File tree

3 files changed

+29
-2
lines changed

3 files changed

+29
-2
lines changed

.github/workflows/oracle.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,5 +74,5 @@ jobs:
7474
uses: actions/upload-artifact@v4
7575
if: ${{ failure() && steps.test.conclusion == 'failure' }}
7676
with:
77-
name: surefire-test-reports
77+
name: surefire-test-reports-${{ matrix.oracle }}
7878
path: '**/target/surefire-reports/*'

.github/workflows/sql-server.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,5 +71,5 @@ jobs:
7171
uses: actions/upload-artifact@v4
7272
if: ${{ failure() && steps.test.conclusion == 'failure' }}
7373
with:
74-
name: surefire-test-reports
74+
name: surefire-test-reports-${{ matrix.mssql }}
7575
path: '**/target/surefire-reports/*'

modules/flowable-app-engine-rest/src/test/java/org/flowable/app/rest/service/api/repository/DeploymentCollectionResourceTest.java

+27
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,33 @@ public void testGetDeployments() throws Exception {
8787
// Check without tenantId filtering
8888
url = baseUrl + "?withoutTenantId=true";
8989
assertResultsPresentInDataResponse(url, firstDeployment.getId());
90+
} finally {
91+
// Always cleanup any created deployments, even if the test failed
92+
List<AppDeployment> deployments = repositoryService.createDeploymentQuery().list();
93+
for (AppDeployment deployment : deployments) {
94+
repositoryService.deleteDeployment(deployment.getId(), true);
95+
}
96+
}
97+
}
98+
99+
public void testGetDeploymentsSorting() throws Exception {
100+
101+
try {
102+
// Alter time to ensure different deployTimes
103+
Calendar yesterday = Calendar.getInstance();
104+
yesterday.add(Calendar.DAY_OF_MONTH, -1);
105+
appEngineConfiguration.getClock().setCurrentTime(yesterday.getTime());
106+
107+
AppDeployment firstDeployment = repositoryService.createDeployment().name("Deployment 1").category("DEF")
108+
.addClasspathResource("org/flowable/app/rest/service/api/repository/oneApp.app")
109+
.tenantId("acme")
110+
.deploy();
111+
112+
appEngineConfiguration.getClock().setCurrentTime(Calendar.getInstance().getTime());
113+
AppDeployment secondDeployment = repositoryService.createDeployment().name("Deployment 2").category("ABC")
114+
.addClasspathResource("org/flowable/app/rest/service/api/repository/oneApp.app")
115+
.tenantId("myTenant")
116+
.deploy();
90117

91118
// Check ordering by name
92119
CloseableHttpResponse response = executeRequest(

0 commit comments

Comments
 (0)