Skip to content

Commit 6bfb841

Browse files
authored
fix: side effects function should not save when no changes (#541)
1 parent 6b85b27 commit 6bfb841

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/org/authInfo.ts

+7-5
Original file line numberDiff line numberDiff line change
@@ -571,16 +571,18 @@ export class AuthInfo extends AsyncOptionalCreatable<AuthInfo.Options> {
571571

572572
/**
573573
* Convenience function to handle typical side effects encountered when dealing with an AuthInfo.
574-
* Given the values supplied in parameter sideEffects, this functions will set auth alias, default auth
574+
* Given the values supplied in parameter sideEffects, this function will set auth alias, default auth
575575
* and default dev hub.
576576
*
577577
* @param sideEffects - instance of AuthSideEffects
578578
*/
579579
public async handleAliasAndDefaultSettings(sideEffects: AuthSideEffects): Promise<void> {
580-
if (sideEffects.alias) await this.setAlias(sideEffects.alias);
581-
if (sideEffects.setDefault) await this.setAsDefault({ org: true });
582-
if (sideEffects.setDefaultDevHub) await this.setAsDefault({ devHub: true });
583-
await this.save();
580+
if (sideEffects.alias || sideEffects.setDefault || sideEffects.setDefaultDevHub) {
581+
if (sideEffects.alias) await this.setAlias(sideEffects.alias);
582+
if (sideEffects.setDefault) await this.setAsDefault({ org: true });
583+
if (sideEffects.setDefaultDevHub) await this.setAsDefault({ devHub: true });
584+
await this.save();
585+
}
584586
}
585587

586588
/**

0 commit comments

Comments
 (0)