Skip to content

Commit caa2a16

Browse files
ellenspfreakydude
authored andcommitted
🩹 Fix DGUS (MKS) compile (MarlinFirmware#24378)
1 parent 0d2fbe5 commit caa2a16

File tree

5 files changed

+23
-19
lines changed

5 files changed

+23
-19
lines changed

Marlin/src/feature/pause.cpp

+7-3
Original file line numberDiff line numberDiff line change
@@ -711,9 +711,13 @@ void resume_print(const_float_t slow_load_length/*=0*/, const_float_t fast_load_
711711

712712
TERN_(HAS_FILAMENT_SENSOR, runout.reset());
713713

714-
TERN(DWIN_LCD_PROUI, DWIN_Print_Resume(), ui.reset_status());
715-
TERN_(HAS_MARLINUI_MENU, ui.return_to_status());
716-
TERN_(DWIN_LCD_PROUI, HMI_ReturnScreen());
714+
#if ENABLED(DWIN_LCD_PROUI)
715+
DWIN_Print_Resume();
716+
HMI_ReturnScreen();
717+
#else
718+
ui.reset_status();
719+
ui.return_to_status();
720+
#endif
717721
}
718722

719723
#endif // ADVANCED_PAUSE_FEATURE

Marlin/src/inc/Conditionals_LCD.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -513,7 +513,7 @@
513513
#define HAS_LCDPRINT 1
514514
#endif
515515

516-
#if ANY(HAS_DISPLAY, HAS_DWIN_E3V2)
516+
#if HAS_DISPLAY || HAS_DWIN_E3V2
517517
#define HAS_STATUS_MESSAGE 1
518518
#endif
519519

Marlin/src/inc/Conditionals_adv.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -1018,13 +1018,13 @@
10181018
* LCD_SERIAL_PORT must be defined ahead of HAL.h
10191019
*/
10201020
#ifndef LCD_SERIAL_PORT
1021-
#if HAS_DWIN_E3V2 || IS_DWIN_MARLINUI
1021+
#if HAS_DWIN_E3V2 || IS_DWIN_MARLINUI || HAS_DGUS_LCD
10221022
#if MB(BTT_SKR_MINI_E3_V1_0, BTT_SKR_MINI_E3_V1_2, BTT_SKR_MINI_E3_V2_0, BTT_SKR_MINI_E3_V3_0, BTT_SKR_E3_TURBO)
10231023
#define LCD_SERIAL_PORT 1
1024-
#elif MB(CREALITY_V24S1_301, CREALITY_V24S1_301F4, CREALITY_V423)
1025-
#define LCD_SERIAL_PORT 2 // Creality Ender3S1 board
1024+
#elif MB(CREALITY_V24S1_301, CREALITY_V24S1_301F4, CREALITY_V423, MKS_ROBIN)
1025+
#define LCD_SERIAL_PORT 2 // Creality Ender3S1, MKS Robin
10261026
#else
1027-
#define LCD_SERIAL_PORT 3 // Creality 4.x board
1027+
#define LCD_SERIAL_PORT 3 // Other boards
10281028
#endif
10291029
#endif
10301030
#ifdef LCD_SERIAL_PORT

Marlin/src/lcd/extui/dgus/mks/DGUSScreenHandler.cpp

+9-10
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ void DGUSScreenHandlerMKS::DGUSLCD_SendTMCStepValue(DGUS_VP_Variable &var) {
258258
) filelist.refresh();
259259
}
260260

261-
void DGUSScreenHandler::SDPrintingFinished() {
261+
void DGUSScreenHandlerMKS::SDPrintingFinished() {
262262
if (DGUSAutoTurnOff) {
263263
queue.exhaust();
264264
gcode.process_subcommands_now(F("M81"));
@@ -416,15 +416,15 @@ void DGUSScreenHandlerMKS::LanguageChange(DGUS_VP_Variable &var, void *val_ptr)
416416
case MKS_SimpleChinese:
417417
DGUS_LanguageDisplay(MKS_SimpleChinese);
418418
mks_language_index = MKS_SimpleChinese;
419-
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE1, MKS_Language_Choose);
420-
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE2, MKS_Language_NoChoose);
419+
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE1, (uint8_t)MKS_Language_Choose);
420+
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE2, (uint8_t)MKS_Language_NoChoose);
421421
settings.save();
422422
break;
423423
case MKS_English:
424424
DGUS_LanguageDisplay(MKS_English);
425425
mks_language_index = MKS_English;
426-
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE1, MKS_Language_NoChoose);
427-
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE2, MKS_Language_Choose);
426+
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE1, (uint8_t)MKS_Language_NoChoose);
427+
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE2, (uint8_t)MKS_Language_Choose);
428428
settings.save();
429429
break;
430430
default: break;
@@ -1125,7 +1125,6 @@ void DGUSScreenHandlerMKS::HandleAccChange(DGUS_VP_Variable &var, void *val_ptr)
11251125
#if ENABLED(BABYSTEPPING)
11261126
void DGUSScreenHandler::HandleLiveAdjustZ(DGUS_VP_Variable &var, void *val_ptr) {
11271127
DEBUG_ECHOLNPGM("HandleLiveAdjustZ");
1128-
char babystep_buf[30];
11291128
float step = ZOffset_distance;
11301129

11311130
uint16_t flag = swap16(*(uint16_t*)val_ptr);
@@ -1446,12 +1445,12 @@ bool DGUSScreenHandlerMKS::loop() {
14461445
void DGUSScreenHandlerMKS::LanguagePInit() {
14471446
switch (mks_language_index) {
14481447
case MKS_SimpleChinese:
1449-
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE1, MKS_Language_Choose);
1450-
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE2, MKS_Language_NoChoose);
1448+
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE1, (uint8_t)MKS_Language_Choose);
1449+
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE2, (uint8_t)MKS_Language_NoChoose);
14511450
break;
14521451
case MKS_English:
1453-
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE1, MKS_Language_NoChoose);
1454-
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE2, MKS_Language_Choose);
1452+
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE1, (uint8_t)MKS_Language_NoChoose);
1453+
dgusdisplay.WriteVariable(VP_LANGUAGE_CHANGE2, (uint8_t)MKS_Language_Choose);
14551454
break;
14561455
default:
14571456
break;

Marlin/src/lcd/marlinui.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,6 @@ class MarlinUI {
502502
#else // No LCD
503503

504504
static void update() {}
505-
static void return_to_status() {}
506505
static void kill_screen(FSTR_P const, FSTR_P const) {}
507506

508507
#endif
@@ -609,6 +608,8 @@ class MarlinUI {
609608

610609
#else
611610

611+
static void return_to_status() {}
612+
612613
static constexpr bool on_status_screen() { return true; }
613614

614615
#if HAS_WIRED_LCD

0 commit comments

Comments
 (0)