Skip to content

Commit f9dfbe9

Browse files
committedMar 11, 2025
FIXUP: Make tests work after 'podman load -i'
1 parent 49d4546 commit f9dfbe9

File tree

1 file changed

+16
-10
lines changed

1 file changed

+16
-10
lines changed
 

‎tests/isolation_provider/test_container.py

+16-10
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
from dangerzone import container_utils, errors
99
from dangerzone.isolation_provider.container import Container
1010
from dangerzone.isolation_provider.qubes import is_qubes_native_conversion
11+
from dangerzone.util import get_resource_path
1112

1213
from .base import IsolationProviderTermination, IsolationProviderTest
1314

@@ -47,7 +48,7 @@ def test_is_available_works(self, provider: Container, fp: FakeProcess) -> None:
4748
provider.is_available()
4849

4950
def test_install_raise_if_image_cant_be_installed(
50-
self, mocker: MockerFixture, provider: Container, fp: FakeProcess
51+
self, provider: Container, fp: FakeProcess
5152
) -> None:
5253
"""When an image installation fails, an exception should be raised"""
5354

@@ -68,19 +69,21 @@ def test_install_raise_if_image_cant_be_installed(
6869
occurrences=2,
6970
)
7071

71-
# Make podman load fail
72-
mocker.patch("builtins.open", mocker.mock_open(read_data=""))
73-
7472
fp.register_subprocess(
75-
[container_utils.get_runtime(), "load"],
73+
[
74+
container_utils.get_runtime(),
75+
"load",
76+
"-i",
77+
get_resource_path("container.tar"),
78+
],
7679
returncode=-1,
7780
)
7881

7982
with pytest.raises(errors.ImageInstallationException):
8083
provider.install()
8184

8285
def test_install_raises_if_still_not_installed(
83-
self, mocker: MockerFixture, provider: Container, fp: FakeProcess
86+
self, provider: Container, fp: FakeProcess
8487
) -> None:
8588
"""When an image keep being not installed, it should return False"""
8689
fp.register_subprocess(
@@ -105,10 +108,13 @@ def test_install_raises_if_still_not_installed(
105108
occurrences=2,
106109
)
107110

108-
# Patch open and podman load so that it works
109-
mocker.patch("builtins.open", mocker.mock_open(read_data=""))
110111
fp.register_subprocess(
111-
[container_utils.get_runtime(), "load"],
112+
[
113+
container_utils.get_runtime(),
114+
"load",
115+
"-i",
116+
get_resource_path("container.tar"),
117+
],
112118
)
113119
with pytest.raises(errors.ImageNotPresentException):
114120
provider.install()
@@ -195,7 +201,7 @@ def test_docker_desktop_version_failure_returns_true(
195201
reason="Linux specific",
196202
)
197203
def test_linux_skips_desktop_version_check_returns_true(
198-
self, mocker: MockerFixture, provider: Container
204+
self, provider: Container
199205
) -> None:
200206
assert (True, "") == provider.check_docker_desktop_version()
201207

0 commit comments

Comments
 (0)