Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce build flag GLUON_LEGACY #1737

Closed
rotanid opened this issue Jun 6, 2019 · 1 comment · Fixed by #1745
Closed

introduce build flag GLUON_LEGACY #1737

rotanid opened this issue Jun 6, 2019 · 1 comment · Fixed by #1745
Assignees
Labels
0. type: enhancement The changeset is an enhancement 1. severity: blocker This issue/pr is required for the next release
Milestone

Comments

@rotanid
Copy link
Member

rotanid commented Jun 6, 2019

flag a target as legacy, requiring firmware builders to decide whether to build only sysupgrade or sysupgrade and factory images

GLUON_LEGACY={false,true,sysupgrade}

@rotanid rotanid added 0. type: enhancement The changeset is an enhancement 1. severity: blocker This issue/pr is required for the next release labels Jun 6, 2019
@rotanid rotanid added this to the 2019.1 milestone Jun 6, 2019
@neocturne neocturne self-assigned this Jun 11, 2019
@neocturne
Copy link
Member

While I don't have a strong opinion on this (and will hopefully not turn this issue into a bikeshedding discussion), I think I'll go with the following values for GLUON_LEGACY:

  • 0: don't build any legacy images
  • 1: build legacy sysupgrade images
  • full: build legacy sysupgrade and factory images

This has two advantages in my opinion:

  • 0/1 is already used for other options
  • having a separate value for the "sysupgrade+factory" setting rather than for the "sysupgrade only" setting makes this option special, hopefully hinting site builders at not choosing this option ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. type: enhancement The changeset is an enhancement 1. severity: blocker This issue/pr is required for the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants