Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide lein profile for the specific sensor #33

Open
mishadoff opened this issue May 8, 2019 · 3 comments
Open

Provide lein profile for the specific sensor #33

mishadoff opened this issue May 8, 2019 · 3 comments
Labels
feature New feature or request

Comments

@mishadoff
Copy link
Contributor

mishadoff commented May 8, 2019

It would be good to have ability to provide lein profile for the specific sensor.

For example, we encountered a lot of vulnerabilities in nvd sensor, due to some abandoned dependencies in tests. They are good to solve, but they should not fail quality gates, because they are not "vulnerabilities" and not included into deployed app at all.

As one solution to that would be to run lein with-profile release nvd check. But profiles are not customizable. Can we add an option to customize lein profile per sensor or there is better way to do it?

More extensible, but risky approach would be to allow user customize every sensor by providing LEIN_ARGUMENTS, this way we can customize not only profiles but other options to lein plugins (like eastwood and kibit excluded rules, namespaces for cloverage, etc.)

@mishadoff mishadoff added the feature New feature or request label May 8, 2019
@fsantiag
Copy link
Owner

Hi @mishadoff, thank you for your contribution and sorry for the late reply.

As per your suggestion, if nvd sensor is reporting a vulnerability (even in the tests), I believe you should try to fix it instead of relaxing/skipping the rules, don't you think? I know sometimes it can generate a false positive, however for those scenarios I think you can change the Quality Gate on Sonarqube to prevent it from failing. Does that make sense? I might have misunderstood something, though. Let me know if you have other thoughts.

@mishadoff
Copy link
Contributor Author

All those are definitely options, but providing lein profile for specific sensor would still be beloved feature in my opinion.

@fsantiag
Copy link
Owner

fsantiag commented Apr 28, 2020

I will see if I can expose a custom attribute in the sonar-project.properties to set the profile. Something like sonar.clojure.lein.profile=dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants