Skip to content

Commit 898bdad

Browse files
authored
fixup release process (#328)
1 parent 25c896a commit 898bdad

File tree

2 files changed

+2
-18
lines changed

2 files changed

+2
-18
lines changed

releasing/README.md

+1-16
Original file line numberDiff line numberDiff line change
@@ -53,22 +53,7 @@ This will create the release in GitHub with provisional release notes that just
5353

5454
### Docker Hub Releases
5555

56-
To re-run only the Docker Hub release steps, we need to build an image with the right tag and then push to Docker Hub.
57-
58-
```sh
59-
# from the root of the repo
60-
echo v2.3.4 > VERSION
61-
docker build -t fullstorydev/grpcurl:v2.3.4 .
62-
docker build -t fullstorydev/grpcurl:v2.3.4-alpine --target alpine .
63-
# now that we have it built, push to Docker Hub
64-
docker push fullstorydev/grpcurl:v2.3.4
65-
docker push fullstorydev/grpcurl:v2.3.4-alpine
66-
# push "latest" tag, too
67-
docker tag fullstorydev/grpcurl:v2.3.4 fullstorydev/grpcurl:latest
68-
docker tag fullstorydev/grpcurl:v2.3.4-alpine fullstorydev/grpcurl:latest-alpine
69-
docker push fullstorydev/grpcurl:latest
70-
docker push fullstorydev/grpcurl:latest-alpine
71-
```
56+
To re-run only the Docker Hub release steps, you can manually run through each step in the "Docker" section of `do_release.sh`.
7257

7358
If the `docker push ...` steps fail, you may need to run `docker login`, enter your Docker Hub login credentials, and then try to push again.
7459

releasing/do-release.sh

+1-2
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,7 @@ export DOCKER_CLI_EXPERIMENTAL=enabled
5050
$PREFIX docker buildx create --use --name multiarch-builder --node multiarch-builder0
5151
# push to docker hub, both the given version as a tag and for "latest" tag
5252
$PREFIX docker buildx build --platform linux/amd64,linux/s390x,linux/arm64,linux/ppc64le --tag fullstorydev/grpcurl:${VERSION} --tag fullstorydev/grpcurl:latest --push --progress plain --no-cache .
53-
rm VERSION
54-
$PREFIX docker buildx build --platform linux/amd64,linux/s390x,linux/arm64 --tag fullstorydev/grpcurl:${VERSION}-alpine --tag fullstorydev/grpcurl:latest-alpine --push --progress plain --no-cache --target alpine .
53+
$PREFIX docker buildx build --platform linux/amd64,linux/s390x,linux/arm64,linux/ppc64le --tag fullstorydev/grpcurl:${VERSION}-alpine --tag fullstorydev/grpcurl:latest-alpine --push --progress plain --no-cache --target alpine .
5554
rm VERSION
5655

5756
# Homebrew release

0 commit comments

Comments
 (0)