Skip to content

Commit 1a850ad

Browse files
Block Editor: Bug fixes targeted for WordPress 5.3 RC4.
The list of included fixes is: WordPress/gutenberg#18183 WordPress/gutenberg#18194 WordPress/gutenberg#18230 WordPress/gutenberg#18275 WordPress/gutenberg#18287 Updated packages: - @wordpress/block-editor@3.2.4 - @wordpress/block-library@2.9.5 - @wordpress/edit-post@3.8.5 - @wordpress/editor@9.7.5 - @wordpress/format-library@1.9.4 Props @aduth, @mcsf, @youknowriad, @johnbillion. Fixes #48502. Built from https://develop.svn.wordpress.org/trunk@46656 git-svn-id: https://core.svn.wordpress.org/trunk@46456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
1 parent 273d7c9 commit 1a850ad

28 files changed

+289
-157
lines changed

wp-includes/css/dist/block-editor/style-rtl.css

-17
Original file line numberDiff line numberDiff line change
@@ -527,23 +527,6 @@
527527
.block-editor-block-list__block.is-multi-selected > .block-editor-block-mover {
528528
right: -30px; }
529529

530-
.block-editor-block-list__block[data-align="left"].is-selected > .block-editor-block-list__block-edit > .block-editor-block-mover, .block-editor-block-list__block[data-align="right"].is-selected > .block-editor-block-list__block-edit > .block-editor-block-mover {
531-
display: none; }
532-
@media (min-width: 600px) {
533-
.block-editor-block-list__block[data-align="left"].is-selected > .block-editor-block-list__block-edit > .block-editor-block-mover, .block-editor-block-list__block[data-align="right"].is-selected > .block-editor-block-list__block-edit > .block-editor-block-mover {
534-
display: block;
535-
opacity: 1;
536-
animation: none;
537-
width: 45px;
538-
height: auto;
539-
padding-bottom: 14px;
540-
margin-top: 0; } }
541-
542-
.block-editor-block-list__block[data-align="left"].is-hovered > .block-editor-block-list__block-edit > .block-editor-block-mover,
543-
.block-editor-block-list__block[data-align="left"].is-dragging > .block-editor-block-list__block-edit > .block-editor-block-mover, .block-editor-block-list__block[data-align="right"].is-hovered > .block-editor-block-list__block-edit > .block-editor-block-mover,
544-
.block-editor-block-list__block[data-align="right"].is-dragging > .block-editor-block-list__block-edit > .block-editor-block-mover {
545-
display: none; }
546-
547530
/**
548531
* Mobile unified toolbar.
549532
*/

wp-includes/css/dist/block-editor/style-rtl.min.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wp-includes/css/dist/block-editor/style.css

-17
Original file line numberDiff line numberDiff line change
@@ -539,23 +539,6 @@
539539
.block-editor-block-list__block.is-multi-selected > .block-editor-block-mover {
540540
left: -30px; }
541541

542-
.block-editor-block-list__block[data-align="left"].is-selected > .block-editor-block-list__block-edit > .block-editor-block-mover, .block-editor-block-list__block[data-align="right"].is-selected > .block-editor-block-list__block-edit > .block-editor-block-mover {
543-
display: none; }
544-
@media (min-width: 600px) {
545-
.block-editor-block-list__block[data-align="left"].is-selected > .block-editor-block-list__block-edit > .block-editor-block-mover, .block-editor-block-list__block[data-align="right"].is-selected > .block-editor-block-list__block-edit > .block-editor-block-mover {
546-
display: block;
547-
opacity: 1;
548-
animation: none;
549-
width: 45px;
550-
height: auto;
551-
padding-bottom: 14px;
552-
margin-top: 0; } }
553-
554-
.block-editor-block-list__block[data-align="left"].is-hovered > .block-editor-block-list__block-edit > .block-editor-block-mover,
555-
.block-editor-block-list__block[data-align="left"].is-dragging > .block-editor-block-list__block-edit > .block-editor-block-mover, .block-editor-block-list__block[data-align="right"].is-hovered > .block-editor-block-list__block-edit > .block-editor-block-mover,
556-
.block-editor-block-list__block[data-align="right"].is-dragging > .block-editor-block-list__block-edit > .block-editor-block-mover {
557-
display: none; }
558-
559542
/**
560543
* Mobile unified toolbar.
561544
*/

wp-includes/css/dist/block-editor/style.min.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wp-includes/css/dist/block-library/editor-rtl.css

+5-2
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ div[data-type="core/button"] div[data-block] {
180180
display: flex;
181181
flex-direction: column;
182182
flex: 1 1 auto; }
183-
@supports (position: sticky) {
183+
@supports ((position: -webkit-sticky) or (position: sticky)) {
184184
.wp-block-columns > .editor-inner-blocks > .editor-block-list__layout > [data-type="core/column"],
185185
.wp-block-columns > .editor-inner-blocks > .editor-block-list__layout > [data-type="core/column"] > .editor-block-list__block-edit,
186186
.wp-block-columns > .editor-inner-blocks > .editor-block-list__layout > [data-type="core/column"] > .editor-block-list__block-edit > div[data-block],
@@ -600,6 +600,7 @@ div[data-type="core/freeform"].is-selected .block-library-rich-text__tinymce::af
600600
display: none;
601601
width: auto;
602602
margin: 0 -14px;
603+
position: -webkit-sticky;
603604
position: sticky;
604605
z-index: 10;
605606
top: 14px;
@@ -697,7 +698,7 @@ body.admin-color-light .blocks-gallery-item figure.is-selected {
697698
max-height: 100%;
698699
overflow-y: auto; }
699700

700-
@supports (position: sticky) {
701+
@supports ((position: -webkit-sticky) or (position: sticky)) {
701702
.blocks-gallery-item .is-selected .block-editor-rich-text {
702703
left: 0;
703704
right: 0;
@@ -1134,6 +1135,7 @@ figure.block-library-media-text__media-container {
11341135
.wp-block-navigation-menu {
11351136
display: -ms-grid;
11361137
display: grid;
1138+
grid-auto-columns: -webkit-min-content;
11371139
grid-auto-columns: min-content;
11381140
grid-auto-flow: column;
11391141
align-items: center;
@@ -1146,6 +1148,7 @@ figure.block-library-media-text__media-container {
11461148
.wp-block-navigation-menu-item__edit-container {
11471149
display: -ms-grid;
11481150
display: grid;
1151+
grid-auto-columns: -webkit-min-content;
11491152
grid-auto-columns: min-content;
11501153
grid-auto-flow: column;
11511154
align-items: center;

wp-includes/css/dist/block-library/editor-rtl.min.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wp-includes/css/dist/block-library/editor.css

+5-2
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ div[data-type="core/button"] div[data-block] {
181181
display: flex;
182182
flex-direction: column;
183183
flex: 1 1 auto; }
184-
@supports (position: sticky) {
184+
@supports ((position: -webkit-sticky) or (position: sticky)) {
185185
.wp-block-columns > .editor-inner-blocks > .editor-block-list__layout > [data-type="core/column"],
186186
.wp-block-columns > .editor-inner-blocks > .editor-block-list__layout > [data-type="core/column"] > .editor-block-list__block-edit,
187187
.wp-block-columns > .editor-inner-blocks > .editor-block-list__layout > [data-type="core/column"] > .editor-block-list__block-edit > div[data-block],
@@ -605,6 +605,7 @@ div[data-type="core/freeform"].is-selected .block-library-rich-text__tinymce::af
605605
display: none;
606606
width: auto;
607607
margin: 0 -14px;
608+
position: -webkit-sticky;
608609
position: sticky;
609610
z-index: 10;
610611
top: 14px;
@@ -702,7 +703,7 @@ body.admin-color-light .blocks-gallery-item figure.is-selected {
702703
max-height: 100%;
703704
overflow-y: auto; }
704705

705-
@supports (position: sticky) {
706+
@supports ((position: -webkit-sticky) or (position: sticky)) {
706707
.blocks-gallery-item .is-selected .block-editor-rich-text {
707708
right: 0;
708709
left: 0;
@@ -1139,6 +1140,7 @@ figure.block-library-media-text__media-container {
11391140
.wp-block-navigation-menu {
11401141
display: -ms-grid;
11411142
display: grid;
1143+
grid-auto-columns: -webkit-min-content;
11421144
grid-auto-columns: min-content;
11431145
grid-auto-flow: column;
11441146
align-items: center;
@@ -1151,6 +1153,7 @@ figure.block-library-media-text__media-container {
11511153
.wp-block-navigation-menu-item__edit-container {
11521154
display: -ms-grid;
11531155
display: grid;
1156+
grid-auto-columns: -webkit-min-content;
11541157
grid-auto-columns: min-content;
11551158
grid-auto-flow: column;
11561159
align-items: center;

wp-includes/css/dist/block-library/editor.min.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wp-includes/css/dist/block-library/style-rtl.css

+27-26
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@
3838
/**
3939
* Reset the WP Admin page styles for Gutenberg-like pages.
4040
*/
41+
.wp-block-audio figcaption {
42+
margin-top: 0.5em;
43+
margin-bottom: 1em; }
44+
4145
.wp-block-audio audio {
4246
width: 100%;
4347
min-width: 300px; }
@@ -234,7 +238,7 @@
234238
content: "";
235239
font-size: 0;
236240
min-height: inherit; }
237-
@supports (position: sticky) {
241+
@supports ((position: -webkit-sticky) or (position: sticky)) {
238242
.wp-block-cover-image::after,
239243
.wp-block-cover::after {
240244
content: none; } }
@@ -335,6 +339,9 @@ section.wp-block-cover-image > h2,
335339

336340
.wp-block-embed {
337341
margin-bottom: 1em; }
342+
.wp-block-embed figcaption {
343+
margin-top: 0.5em;
344+
margin-bottom: 1em; }
338345

339346
.wp-embed-responsive .wp-block-embed.wp-embed-aspect-21-9 .wp-block-embed__wrapper,
340347
.wp-embed-responsive .wp-block-embed.wp-embed-aspect-18-9 .wp-block-embed__wrapper,
@@ -435,7 +442,7 @@ section.wp-block-cover-image > h2,
435442
.blocks-gallery-grid .blocks-gallery-item figure {
436443
margin: 0;
437444
height: 100%; }
438-
@supports (position: sticky) {
445+
@supports ((position: -webkit-sticky) or (position: sticky)) {
439446
.wp-block-gallery .blocks-gallery-image figure,
440447
.wp-block-gallery .blocks-gallery-item figure,
441448
.blocks-gallery-grid .blocks-gallery-image figure,
@@ -455,7 +462,7 @@ section.wp-block-cover-image > h2,
455462
.blocks-gallery-grid .blocks-gallery-image img,
456463
.blocks-gallery-grid .blocks-gallery-item img {
457464
width: 100%; }
458-
@supports (position: sticky) {
465+
@supports ((position: -webkit-sticky) or (position: sticky)) {
459466
.wp-block-gallery .blocks-gallery-image img,
460467
.wp-block-gallery .blocks-gallery-item img,
461468
.blocks-gallery-grid .blocks-gallery-image img,
@@ -489,7 +496,7 @@ section.wp-block-cover-image > h2,
489496
.blocks-gallery-grid.is-cropped .blocks-gallery-item a,
490497
.blocks-gallery-grid.is-cropped .blocks-gallery-item img {
491498
width: 100%; }
492-
@supports (position: sticky) {
499+
@supports ((position: -webkit-sticky) or (position: sticky)) {
493500
.wp-block-gallery.is-cropped .blocks-gallery-image a,
494501
.wp-block-gallery.is-cropped .blocks-gallery-image img,
495502
.wp-block-gallery.is-cropped .blocks-gallery-item a,
@@ -675,18 +682,25 @@ section.wp-block-cover-image > h2,
675682
.wp-block-image .aligncenter {
676683
margin-right: auto;
677684
margin-left: auto; }
685+
.wp-block-image figcaption {
686+
margin-top: 0.5em;
687+
margin-bottom: 1em; }
678688

679689
.is-style-circle-mask img {
680690
border-radius: 9999px; }
681-
@supports (mask-image: none) or (-webkit-mask-image: none) {
691+
@supports ((-webkit-mask-image: none) or (mask-image: none)) or (-webkit-mask-image: none) {
682692
.is-style-circle-mask img {
683693
/* stylelint-disable */
684-
mask-image: url('data:image/svg+xml;utf8,<svg viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg"><circle cx="50" cy="50" r="50"/></svg>');
694+
-webkit-mask-image: url('data:image/svg+xml;utf8,<svg viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg"><circle cx="50" cy="50" r="50"/></svg>');
695+
mask-image: url('data:image/svg+xml;utf8,<svg viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg"><circle cx="50" cy="50" r="50"/></svg>');
685696
/* stylelint-enable */
686697
mask-mode: alpha;
687-
mask-repeat: no-repeat;
688-
mask-size: contain;
689-
mask-position: center;
698+
-webkit-mask-repeat: no-repeat;
699+
mask-repeat: no-repeat;
700+
-webkit-mask-size: contain;
701+
mask-size: contain;
702+
-webkit-mask-position: center;
703+
mask-position: center;
690704
border-radius: none; } }
691705

692706
.wp-block-latest-comments__comment {
@@ -1401,12 +1415,15 @@ pre.wp-block-verse {
14011415
margin-left: 0; }
14021416
.wp-block-video video {
14031417
max-width: 100%; }
1404-
@supports (position: sticky) {
1418+
@supports ((position: -webkit-sticky) or (position: sticky)) {
14051419
.wp-block-video [poster] {
14061420
-o-object-fit: cover;
14071421
object-fit: cover; } }
14081422
.wp-block-video.aligncenter {
14091423
text-align: center; }
1424+
.wp-block-video figcaption {
1425+
margin-top: 0.5em;
1426+
margin-bottom: 1em; }
14101427

14111428
:root .has-pale-pink-background-color {
14121429
background-color: #f78da7; }
@@ -1505,19 +1522,3 @@ pre.wp-block-verse {
15051522

15061523
.has-text-align-right {
15071524
text-align: right; }
1508-
1509-
/**
1510-
* Vanilla Block Styles
1511-
* These are base styles that apply across blocks, meant to provide a baseline.
1512-
* They are applied both to the editor and the theme, so we should have as few of these as possible.
1513-
* Please note that some styles are stored in packages/editor/src/editor-styles.scss, as they pertain to CSS bleed for the editor only.
1514-
*/
1515-
figcaption {
1516-
margin-top: 0.5em; }
1517-
1518-
img {
1519-
max-width: 100%;
1520-
height: auto; }
1521-
1522-
iframe {
1523-
width: 100%; }

wp-includes/css/dist/block-library/style-rtl.min.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

wp-includes/css/dist/block-library/style.css

+27-26
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@
3838
/**
3939
* Reset the WP Admin page styles for Gutenberg-like pages.
4040
*/
41+
.wp-block-audio figcaption {
42+
margin-top: 0.5em;
43+
margin-bottom: 1em; }
44+
4145
.wp-block-audio audio {
4246
width: 100%;
4347
min-width: 300px; }
@@ -237,7 +241,7 @@
237241
content: "";
238242
font-size: 0;
239243
min-height: inherit; }
240-
@supports (position: sticky) {
244+
@supports ((position: -webkit-sticky) or (position: sticky)) {
241245
.wp-block-cover-image::after,
242246
.wp-block-cover::after {
243247
content: none; } }
@@ -338,6 +342,9 @@ section.wp-block-cover-image > h2,
338342

339343
.wp-block-embed {
340344
margin-bottom: 1em; }
345+
.wp-block-embed figcaption {
346+
margin-top: 0.5em;
347+
margin-bottom: 1em; }
341348

342349
.wp-embed-responsive .wp-block-embed.wp-embed-aspect-21-9 .wp-block-embed__wrapper,
343350
.wp-embed-responsive .wp-block-embed.wp-embed-aspect-18-9 .wp-block-embed__wrapper,
@@ -439,7 +446,7 @@ section.wp-block-cover-image > h2,
439446
.blocks-gallery-grid .blocks-gallery-item figure {
440447
margin: 0;
441448
height: 100%; }
442-
@supports (position: sticky) {
449+
@supports ((position: -webkit-sticky) or (position: sticky)) {
443450
.wp-block-gallery .blocks-gallery-image figure,
444451
.wp-block-gallery .blocks-gallery-item figure,
445452
.blocks-gallery-grid .blocks-gallery-image figure,
@@ -459,7 +466,7 @@ section.wp-block-cover-image > h2,
459466
.blocks-gallery-grid .blocks-gallery-image img,
460467
.blocks-gallery-grid .blocks-gallery-item img {
461468
width: 100%; }
462-
@supports (position: sticky) {
469+
@supports ((position: -webkit-sticky) or (position: sticky)) {
463470
.wp-block-gallery .blocks-gallery-image img,
464471
.wp-block-gallery .blocks-gallery-item img,
465472
.blocks-gallery-grid .blocks-gallery-image img,
@@ -493,7 +500,7 @@ section.wp-block-cover-image > h2,
493500
.blocks-gallery-grid.is-cropped .blocks-gallery-item a,
494501
.blocks-gallery-grid.is-cropped .blocks-gallery-item img {
495502
width: 100%; }
496-
@supports (position: sticky) {
503+
@supports ((position: -webkit-sticky) or (position: sticky)) {
497504
.wp-block-gallery.is-cropped .blocks-gallery-image a,
498505
.wp-block-gallery.is-cropped .blocks-gallery-image img,
499506
.wp-block-gallery.is-cropped .blocks-gallery-item a,
@@ -683,18 +690,25 @@ section.wp-block-cover-image > h2,
683690
.wp-block-image .aligncenter {
684691
margin-left: auto;
685692
margin-right: auto; }
693+
.wp-block-image figcaption {
694+
margin-top: 0.5em;
695+
margin-bottom: 1em; }
686696

687697
.is-style-circle-mask img {
688698
border-radius: 9999px; }
689-
@supports (mask-image: none) or (-webkit-mask-image: none) {
699+
@supports ((-webkit-mask-image: none) or (mask-image: none)) or (-webkit-mask-image: none) {
690700
.is-style-circle-mask img {
691701
/* stylelint-disable */
692-
mask-image: url('data:image/svg+xml;utf8,<svg viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg"><circle cx="50" cy="50" r="50"/></svg>');
702+
-webkit-mask-image: url('data:image/svg+xml;utf8,<svg viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg"><circle cx="50" cy="50" r="50"/></svg>');
703+
mask-image: url('data:image/svg+xml;utf8,<svg viewBox="0 0 100 100" xmlns="http://www.w3.org/2000/svg"><circle cx="50" cy="50" r="50"/></svg>');
693704
/* stylelint-enable */
694705
mask-mode: alpha;
695-
mask-repeat: no-repeat;
696-
mask-size: contain;
697-
mask-position: center;
706+
-webkit-mask-repeat: no-repeat;
707+
mask-repeat: no-repeat;
708+
-webkit-mask-size: contain;
709+
mask-size: contain;
710+
-webkit-mask-position: center;
711+
mask-position: center;
698712
border-radius: none; } }
699713

700714
.wp-block-latest-comments__comment {
@@ -1413,12 +1427,15 @@ pre.wp-block-verse {
14131427
margin-right: 0; }
14141428
.wp-block-video video {
14151429
max-width: 100%; }
1416-
@supports (position: sticky) {
1430+
@supports ((position: -webkit-sticky) or (position: sticky)) {
14171431
.wp-block-video [poster] {
14181432
-o-object-fit: cover;
14191433
object-fit: cover; } }
14201434
.wp-block-video.aligncenter {
14211435
text-align: center; }
1436+
.wp-block-video figcaption {
1437+
margin-top: 0.5em;
1438+
margin-bottom: 1em; }
14221439

14231440
:root .has-pale-pink-background-color {
14241441
background-color: #f78da7; }
@@ -1519,19 +1536,3 @@ pre.wp-block-verse {
15191536
.has-text-align-right {
15201537
/*rtl:ignore*/
15211538
text-align: right; }
1522-
1523-
/**
1524-
* Vanilla Block Styles
1525-
* These are base styles that apply across blocks, meant to provide a baseline.
1526-
* They are applied both to the editor and the theme, so we should have as few of these as possible.
1527-
* Please note that some styles are stored in packages/editor/src/editor-styles.scss, as they pertain to CSS bleed for the editor only.
1528-
*/
1529-
figcaption {
1530-
margin-top: 0.5em; }
1531-
1532-
img {
1533-
max-width: 100%;
1534-
height: auto; }
1535-
1536-
iframe {
1537-
width: 100%; }

wp-includes/css/dist/block-library/style.min.css

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)