Remove unnecessary additions from PR

+ revert back to not deriving `PartialOrd` for `Coordinate`
+ remove unused `ConvexHull` trait in graham_hull impl

Author: rmanoka

geo-types/src/coordinate.rs

@@ -9,7 +9,7 @@ use approx::{AbsDiffEq, RelativeEq, UlpsEq};
 /// as an envelope, a precision model, and spatial reference system
 /// information), a `Coordinate` only contains ordinate values and accessor
 /// methods.
-#[derive(Eq, PartialEq, PartialOrd, Clone, Copy, Debug, Hash)]
+#[derive(Eq, PartialEq, Clone, Copy, Debug, Hash)]
 #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
 pub struct Coordinate<T>
 where

geo/src/algorithm/graham_hull.rs

@@ -1,4 +1,4 @@
-use crate::{Coordinate, CoordinateType, LineString};
+use crate::{Coordinate, LineString};
 use super::kernels::*;
 
 // Utility function: swap idx to head(0th position), remove
@@ -87,15 +87,10 @@ where
     output
 }
 
-pub trait ConvexHull {
-    type Scalar: CoordinateType;
-    fn convex_hull(&self) -> LineString<Self::Scalar>;
-}
-
-
 #[cfg(test)]
 mod test {
     use super::*;
+    use geo_types::CoordinateType;
 
     fn is_ccw_convex<T: CoordinateType + HasKernel>(mut ls: &[Coordinate<T>]) -> bool {
         if ls.len() > 1 && ls[0] == ls[ls.len() - 1] {

geo/src/utils.rs

@@ -1,6 +1,7 @@
 //! Internal utility functions, types, and data structures.
 
 use crate::contains::Contains;
+use geo_types::{CoordinateType, Coordinate};
 
 /// Partition a mutable slice in-place so that it contains all elements for
 /// which `predicate(e)` is `true`, followed by all elements for which
@@ -131,21 +132,14 @@ where
 /// other words, point with minimum `x` coord, and breaking
 /// ties with minimum `y` coord. Should only be called on a
 /// non-empty slice with no `nan` coordinates.
-pub fn lexicographically_least_index<T: Copy + PartialOrd>(pts: &[T]) -> usize {
-    assert!(pts.len() > 0);
-
-    let mut min: Option<(usize, T)> = None;
-    for (i, pt) in pts.iter().enumerate() {
-        if let Some((_, min_pt)) = min {
-            if pt < &min_pt {
-                min = Some( (i, *pt) )
-            }
-        } else {
-            min = Some( (i, *pt) )
-        }
-    }
+pub fn lexicographically_least_index<T: CoordinateType>(pts: &[Coordinate<T>]) -> usize {
+
+    pts.iter().enumerate().min_by(
+        |(_, p), (_, q)| p.x.partial_cmp(&q.x).unwrap().then(
+            p.y.partial_cmp(&q.y).unwrap()
+        )
+    ).unwrap().0
 
-    min.unwrap().0
 }
 
 #[cfg(test)]