Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attrs to style elements #39

Closed
pjsier opened this issue Dec 8, 2022 · 0 comments · Fixed by #42
Closed

Add attrs to style elements #39

pjsier opened this issue Dec 8, 2022 · 0 comments · Fixed by #42

Comments

@pjsier
Copy link
Member

pjsier commented Dec 8, 2022

Most of the elements in src/types/style.rs support arbitrary attributes, but they aren't being included in an attrs field HashMap like other elements.

We need to add support for that based on the specification here, and support writing out a combination of attributes stored in their own fields as well as an attrs field. There's an example of this in src/writer.rs in the write_simple_data method

@pjsier pjsier changed the title Add attrs to style elements` Add attrs to style elements Dec 8, 2022
@pjsier pjsier closed this as completed in #42 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant