Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for select value and label prevents valid select from repeat patterns #98

Open
lognaturel opened this issue Feb 25, 2025 · 1 comment

Comments

@lognaturel
Copy link
Member

Some time between July 2023 and February 2025, this form with a select from repeat stopped passing Validate. When I convert it to XForm with --skip_validate, it works as expected in Collect. We have tests in JavaRosa for this form shape. Was there a change in pyxform? Validate? Could we remove that check since pyxform does that work already?

@lognaturel
Copy link
Member Author

My hunch is that this is because pyxform used to inject extra "ghost" inline selects for this pattern and then stopped doing so. Still, I think our best bet is to remove this check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant