Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows CI build failing SqlListenerTests.RecordsSql for .NET Core 3.1 #2189

Closed
mattjohnsonpint opened this issue Feb 17, 2023 · 1 comment · Fixed by #2190
Closed

Windows CI build failing SqlListenerTests.RecordsSql for .NET Core 3.1 #2189

mattjohnsonpint opened this issue Feb 17, 2023 · 1 comment · Fixed by #2190
Assignees
@mattjohnsonpint
Labels
Bug Something isn't working DiagnosticSource Repository Maintenance

Comments

@mattjohnsonpint
Copy link
Contributor

The CI build for Windows started failing recently for SqlListenerTests.RecordsSql, only on .NET Core 3.1.

https://github.com/getsentry/sentry-dotnet/actions/runs/4202147697

Looks like database spans have disappeared.
@mattjohnsonpint mattjohnsonpint self-assigned this Feb 17, 2023
@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile SDKs Feb 17, 2023
@mattjohnsonpint mattjohnsonpint moved this from Needs Discussion to Needs Investigation in Mobile SDKs Feb 17, 2023
@mattjohnsonpint
Copy link
Contributor Author

This is due to Microsoft.Data.SqlClient 5.1.0 (which we bring in transitively through LocalDB) dropping support for .NET Core 3.1. They still have .NET Standard support, but SqlDiagnosticListener is not implemented for that target.

We can workaround for our tests by pinning the last working version.

Note that this means end-user applications that are still running on .NET Core 3.1 or .NET 5 should not update to the latest Microsoft.Data.SqlClient. If they do, they will no longer see DB Spans in Sentry.

This was referenced Feb 18, 2023
Closed
Merged
@github-project-automation github-project-automation bot moved this from Needs Investigation to Done in Mobile SDKs Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattjohnsonpint mattjohnsonpint

Labels
Bug Something isn't working DiagnosticSource Repository Maintenance
Projects
Mobile SDKs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pin LocalDB for .NET Core 3.1 to fix failing test getsentry/sentry-dotnet
1 participant
@mattjohnsonpint