Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi_draw_indirect_count set incorrect count buffer id. #6182

Closed
BlackStone1123 opened this issue Aug 29, 2024 · 2 comments · Fixed by #6194
Closed

multi_draw_indirect_count set incorrect count buffer id. #6182

BlackStone1123 opened this issue Aug 29, 2024 · 2 comments · Fixed by #6194
Labels
type: bug Something isn't working

Comments

@BlackStone1123
Copy link
Contributor

Description
multi_draw_indexed_indirect_count & multi_draw_indirect_count api is regressed since upgrade to v22.0, the root cause is that the count buffer has been set wrong buffer id as code shown in snapshot.

Repro steps
Ideally, a runnable example we can check out.

Expected vs observed behavior
observed behavior: the count buffer has been set to be the same as indirect buffer, which will cause wrong command count in gpu side.
expected behavior: retrieve the count buffer with correct count buffer id.

Extra materials
企业微信截图_1724915160935

Platform
platform: windows
graphics api: vulkan/dx12
wgpu version: 22.1.0

@BlackStone1123 BlackStone1123 changed the title multi_draw_indirect_cout set incorrect count buffer id. multi_draw_indirect_count set incorrect count buffer id. Aug 29, 2024
@teoxoy
Copy link
Member

teoxoy commented Aug 29, 2024

#5884 seems to have regressed this, could you put up a PR that fixes this?

@teoxoy teoxoy added the type: bug Something isn't working label Aug 29, 2024
@BlackStone1123
Copy link
Contributor Author

this is the fixes pr link: #6194

@github-project-automation github-project-automation bot moved this from Todo to Done in WebGPU for Firefox Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants
@teoxoy @BlackStone1123 and others