Skip to content

Commit 7fa99f0

Browse files
fhinkelgibfahn
authored andcommitted
deps: cherry-pick cc55747 from V8 upstream
This fixes the flaky message/console test on our CI. Original commit message: [test/message] Allow numbers to have more than one leading digit. The {NUMBER} regexp only allowed one, leading to occasional test failures such as: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/17156 Bug: Change-Id: I25a08b80640d9af19ba70c61c846163685f1cb82 Reviewed-on: https://chromium-review.googlesource.com/753322 Reviewed-by: Franziska Hinkelmann <franzih@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{nodejs#49109} PR-URL: nodejs#16890 Backport-PR-URL: nodejs#16413 Ref: nodejs/build#936 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 2153adb commit 7fa99f0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

deps/v8/test/message/testcfg.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ def IsFailureOutput(self, testcase):
107107
expected_lines, actual_lines, fillvalue=''):
108108
pattern = re.escape(expected.rstrip() % env)
109109
pattern = pattern.replace("\\*", ".*")
110-
pattern = pattern.replace("\\{NUMBER\\}", "\d(?:\.\d*)?")
110+
pattern = pattern.replace("\\{NUMBER\\}", "\d+(?:\.\d*)?")
111111
pattern = "^%s$" % pattern
112112
if not re.match(pattern, actual):
113113
return True

0 commit comments

Comments
 (0)