Merge pull request #1639 from skshetry/close-lockfile

Byron · web-flow · commit 47147406a593 · 2023-09-02T11:27:02.000+02:00
util: close lockfile after opening successfully
diff --git a/git/util.py b/git/util.py
@@ -935,7 +935,8 @@ def _obtain_lock_or_raise(self) -> None:
             )
 
         try:
-            open(lock_file, mode='w', closefd=True)
+            with open(lock_file, mode='w'):
+                pass
         except OSError as e:
             raise IOError(str(e)) from e
 

Original file line number	Diff line number	Diff line change
`@@ -935,7 +935,8 @@ def _obtain_lock_or_raise(self) -> None:`
`935`	`935`	`)`
`936`	`936`
`937`	`937`	`try:`
`938`		`- open(lock_file, mode='w', closefd=True)`
	`938`	`+ with open(lock_file, mode='w'):`
	`939`	`+ pass`
`939`	`940`	`except OSError as e:`
`940`	`941`	`raise IOError(str(e)) from e`
`941`	`942`