Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] review all usage of copy(), TypedValue assignment, and replace with TV.Copy() and call .DidUpdate() #1360

Open
jaekwon opened this issue Nov 12, 2023 · 0 comments

Comments

@jaekwon
Copy link
Contributor

jaekwon commented Nov 12, 2023

Description

Related to #1305 (comment) from issue #1305 and #1167, all the places where TypedValue is assigned (via copy or list[x] = ...) should be replaced with TV.Copy() where appropriate, and also .DidUpdate() needs to be called.

In the linked example, the uverse.append() function wasn't properly calling .DidUpdate(), and also there were calls to go native copy([]TypedValue, []TypedValue) as well as simple assignment list[x] = ... that needed to be replaced with TV.Copy().

The uverse.copy() function probably needs to be updated, but we should also scan the entire VM code to see if we are missing anything besides other uverse functions and native overrides.

Please include me in the review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

3 participants