You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Related to #1305 (comment) from issue #1305 and #1167, all the places where TypedValue is assigned (via copy or list[x] = ...) should be replaced with TV.Copy() where appropriate, and also .DidUpdate() needs to be called.
In the linked example, the uverse.append() function wasn't properly calling .DidUpdate(), and also there were calls to go native copy([]TypedValue, []TypedValue) as well as simple assignment list[x] = ... that needed to be replaced with TV.Copy().
The uverse.copy() function probably needs to be updated, but we should also scan the entire VM code to see if we are missing anything besides other uverse functions and native overrides.
Please include me in the review process.
The text was updated successfully, but these errors were encountered:
Description
Related to #1305 (comment) from issue #1305 and #1167, all the places where TypedValue is assigned (via copy or list[x] = ...) should be replaced with TV.Copy() where appropriate, and also .DidUpdate() needs to be called.
In the linked example, the uverse.append() function wasn't properly calling .DidUpdate(), and also there were calls to go native copy([]TypedValue, []TypedValue) as well as simple assignment list[x] = ... that needed to be replaced with TV.Copy().
The uverse.copy() function probably needs to be updated, but we should also scan the entire VM code to see if we are missing anything besides other uverse functions and native overrides.
Please include me in the review process.
The text was updated successfully, but these errors were encountered: