Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a crisp shadow rendering effect similar to old classic games #1930

Closed
jasperbrooks79 opened this issue Dec 3, 2020 · 5 comments
Closed

Comments

@jasperbrooks79
Copy link

jasperbrooks79 commented Dec 3, 2020

Describe the project you are working on

A Tomb raider game, possibly a web-running motion comic with anaglyph 3D effect :OO . .

Describe the problem or limitation you are having in your project

I've looked at the shadows in Godot, and they're a bit blurry, since I found it odd, I've been looking at REAL shadows, in real life, for instance at a lamp, and they too are blurry, not sharp . . But, there were some old games, that sort of made ' sharp ' shadows, and it looked amazing . . I really like the pixelated, or vector look, and I was wondering if it was possible to add a setting, so Godot could render shadows realistically, but also like old games, if that makes . .

Here is the effect, or so . . the shadows look blurry, at a distance, but one can see, shadows can also look ' sharp ', sometimes, not sure why, but here . . .

2020-12-03 0319

I've also looked at real shadows, bec. I really confused me, and most of them, have a sort of blurry edge, when I go for walk, so I know they're better, more PBR, physics accurate, so Godot has an AMAZING shadow engine, as is . . But, there were some old games, that looked more like ' games, 3D ', because they had ' sharp ' shadows, I remember F.E.A.R. 1, a really amazing game, that had this . . I don't know if it's super-complex to code, or simulate, but it'd be amazing to have both options . . And, I think this is my last request, or proposal, as Godot 4 now has all the features, I ever dreamed of, or wanted, in games, etc etc . . So nice, it's just wonderful, what Godot 4 is going towards . . I'll try to keep this short, thanks . .

Describe the feature / enhancement and how it helps to overcome the problem or limitation

It'd allow me to have really sharp shadows, like in Half-life 1, so many good games, I really liked, from back when, amazing memories, fun . .
2020-12-03 0323

However, I don't know if this is super-complex, or how to do it, the default shadows in Godot aren't sharp, even with one DirectionalLight :( :( <3 . .

Skærmbillede (737)

If Godot got that, then I could create any game, I ever dreamed of, or wanted, so cool . . Don't know, if this is more hard-ware intensive, bec. I'm noob, thx . . <3

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Well, maybe a toggle somewhere, in project settings, or under the lights, not sure, so shadows look like Half-life image <3 <3 . .

If this enhancement will not be used often, can it be worked around with a few lines of script?

I'm not sure, I am not a pro, on 3D rendering, shaders, graphics, I'm mostly a Blender 3D modeller, basic coder, atm . .

Is there a reason why this should be core and not an add-on in the asset library?

I'm not sure how to get this effect, so I have no idea, where it should be, many older games had it, and they were mind-blowing, to me, and it looked so good, like pixels, vectors, 3D <3 Thx . .

Again, Godot 4 has all my wishes already, but of course, I want more, you know . . If not in Godot 4, maybe Godot 4.2, or later . . Not sure if to ask more features, or simply hope you can finish Godot 4 instead, all my wishes for the engine are in 4.0, so I'm super grateful and, happy, as is . . Outstanding job, superb, can't complain . . Thx <3 . . Now, to keep it short . .

Thank you <3 :D :D . . .

@jasperbrooks79
Copy link
Author

jasperbrooks79 commented Dec 3, 2020

ps, found some examples, from FEAR 1 <3
Skærmbillede (738)

Skærmbillede (739)

It looked really nice, hope it could be a feature or, toggle, default Godot doesn't make this ? . . :O :O <3 . . Really want this effect, it's so cool, amazing . . <3 Thx . . Half-life 1 nostalgia, FEAR 1 was scary but, so cool . . <3 . . it ran really well, on old engines, so I was hoping we could have both realistic shadows, and this simpler version <3 Thx . .

@Calinou
Copy link
Member

Calinou commented Dec 3, 2020

The issue with stencil shadows is that they become very demanding if you have lots of lights. Moreover, stencil shadows also make it very difficult (if not impossible) to follow a proper 3-point lighting system due to the shadows always being fully sharp.

If you want shadow maps to look sharper, disable shadow filtering in the Project Settings (instead of using the default PCF5). In Godot 4.0, you'll be able to tweak shadow blur on a per-light basis using each light's Blur property.

@jasperbrooks79
Copy link
Author

jasperbrooks79 commented Dec 4, 2020

ok, thanks, I didn't know it was actually complex, Godot's lighting system is better, atm . .

also think those old games sort of, cheated, well by having only one light, in the scene, ok it becomes LESS performant than the one there is now, so it's a dead - end, it doesn't scale well, well just really liked the ' look ' of those ' crisp ', pixel shadows, but I have no problem with Godot's current shadow system, ESPECIALLY if it runs faster <3 :O :O . . Thx . . .

Didn't know those ' old ' shadows were actually complex, just thought it was an old, forgotten technique, bec. they made more accurate shadow stuff, didn't know it was actually complex, at all . . well, I really like Godot's shadows, but I miss those old effects, that's all . . also, it might be very complex to actually implement, like a complete re-writing of the lighting system, not just shadows . . wanted to ask, only bec. it LOOKS so cool, it's not bec. I need it, at all . . Thx, for the info . .

<3 :O . .

@atirut-w
Copy link

atirut-w commented Aug 26, 2021

AFAIK most games that have this "crisp" shadows effect doesn't use depthmap-based shadow mapping. I might be wrong but these games appears to be using the Shadow Volume technique. Not sure if it can be implemented in Godot, though.

@Calinou
Copy link
Member

Calinou commented Sep 29, 2021

Closing due to lack of support. Stencil shadows may be implementable by third parties once the renderer is made more scriptable, but they won't be implemented in core Godot since they aren't relevant for most games anymore. Performance constraints in particular make stencil shadows difficult to use in large, complex scenes.

(In 2D, hard shadows are already supported.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants