Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to use native file selection dialog in the editor #7725

Closed
unitycoder opened this issue Sep 18, 2023 · 6 comments
Closed

Add an option to use native file selection dialog in the editor #7725

unitycoder opened this issue Sep 18, 2023 · 6 comments

Comments

@unitycoder
Copy link

unitycoder commented Sep 18, 2023

Describe the project you are working on

Testing godot

Describe the problem or limitation you are having in your project

Custom file browser dialogs are not easy to use (for someone outside godot).
Muscle memory and in general most other applications use standard file dialogs
and standard dialog contains your own Favorite folders, has standard context menu, standard shortcut keys.

Current file dialog:
image

Standard file dialog:
An_ open _file_dialog_from_a_web_browser_on_Windows_10

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Add editor settings option to use native file dialog in editor

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

If this enhancement will not be used often, can it be worked around with a few lines of script?

Is there a reason why this should be core and not an add-on in the asset library?

easier for users to get started with godot and use it (if they are more used to standard file dialogs)
and native file dialog has many more features that are missing from custom file dialog (like favorites, standard context menu, standard shortcut keys (like backspace))

@kobligo
Copy link

kobligo commented Sep 18, 2023

You mean like this? godotengine/godot#79574
It's been merged.

@unitycoder
Copy link
Author

ok nice! can close this then.

@Calinou
Copy link
Member

Calinou commented Sep 18, 2023

Note that this is option not available in the editor itself by design, as Godot's own FileDialog will sometimes expose options that cannot be displayed in a native OS file manager.

However, you can use native file dialogs in your own projects.

@unitycoder unitycoder changed the title Option to use standard browse file browser dialogs Option to use native file selection dialog in Editor Sep 20, 2023
@unitycoder
Copy link
Author

ah ok, yes i meant for editor.. i'll clarify issue and open again.

@unitycoder unitycoder reopened this Sep 20, 2023
@Calinou Calinou changed the title Option to use native file selection dialog in Editor Add an option to use native file selection dialog in Editor Sep 20, 2023
@Calinou Calinou changed the title Add an option to use native file selection dialog in Editor Add an option to use native file selection dialog in the editor Sep 20, 2023
@Calinou
Copy link
Member

Calinou commented Sep 20, 2023

ah ok, yes i meant for editor.. i'll clarify issue and open again.

As I said in my above comment, this currently can't be implemented unless we ensure all existing EditorFileDialogs have their options moved outside of the dialog (i.e. configured before the dialog is open), or we implement the ability to expose checkboxes in native file dialogs. This can be done, but it's a lot of work to provide something that is ultimately less flexible (you can't show arbitrary UI elements in native file dialogs, it's pretty limited).

@Calinou
Copy link
Member

Calinou commented Nov 17, 2024

This was implemented in 4.3, closing.

image

@Calinou Calinou closed this as completed Nov 17, 2024
@Calinou Calinou added this to the 4.3 milestone Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants