Skip to content

Commit 00cc362

Browse files
committedJan 11, 2024
Merge pull request #86647 from AThousandShips/anim_fix
Fix invalid 3-to-4 renames of `add_animation` to `add_animation_library`
2 parents 5cdd0c6 + 4b7ea9f commit 00cc362

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed
 

‎editor/renames_map_3_to_4.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ const char *RenamesMap3To4::gdscript_function_renames[][2] = {
163163

164164
// { "_set_name", "get_tracker_name" }, // XRPositionalTracker -- CameraFeed uses this.
165165
// { "_unhandled_input", "_unhandled_key_input" }, // BaseButton, ViewportContainer -- Breaks Node, FileDialog, SubViewportContainer.
166+
// { "add_animation", "add_animation_library" }, // AnimationPlayer -- Breaks SpriteFrames (and isn't a correct conversion).
166167
// { "create_gizmo", "_create_gizmo" }, // EditorNode3DGizmoPlugin -- May be used.
167168
// { "get_dependencies", "_get_dependencies" }, // ResourceFormatLoader -- Breaks ResourceLoader.
168169
// { "get_extents", "get_size" }, // BoxShape, RectangleShape -- Breaks Decal, VoxelGI, GPUParticlesCollisionBox, GPUParticlesCollisionSDF, GPUParticlesCollisionHeightField, GPUParticlesAttractorBox, GPUParticlesAttractorVectorField, FogVolume
@@ -214,7 +215,6 @@ const char *RenamesMap3To4::gdscript_function_renames[][2] = {
214215
{ "_set_current", "set_current" }, // Camera2D
215216
{ "_set_editor_description", "set_editor_description" }, // Node
216217
{ "_toplevel_raise_self", "_top_level_raise_self" }, // CanvasItem
217-
{ "add_animation", "add_animation_library" }, // AnimationPlayer
218218
{ "add_cancel", "add_cancel_button" }, // AcceptDialog
219219
{ "add_central_force", "apply_central_force" }, //RigidBody2D
220220
{ "add_child_below_node", "add_sibling" }, // Node
@@ -643,7 +643,6 @@ const char *RenamesMap3To4::csharp_function_renames[][2] = {
643643
{ "_SetPlaying", "SetPlaying" }, // AnimatedSprite3D
644644
{ "_ToplevelRaiseSelf", "_TopLevelRaiseSelf" }, // CanvasItem
645645
{ "_UpdateWrapAt", "_UpdateWrapAtColumn" }, // TextEdit
646-
{ "AddAnimation", "AddAnimationLibrary" }, // AnimationPlayer
647646
{ "AddCancel", "AddCancelButton" }, // AcceptDialog
648647
{ "AddCentralForce", "AddConstantCentralForce" }, //RigidBody2D
649648
{ "AddChildBelowNode", "AddSibling" }, // Node

0 commit comments

Comments
 (0)
Please sign in to comment.