Skip to content

Commit 2ca3e47

Browse files
authored
Merge pull request #22642 from YeldhamDev/inspector_metadata
Expose "meta" to the Inspector
2 parents b79303d + e425f2d commit 2ca3e47

7 files changed

+17
-14
lines changed

core/object.cpp

+6-3
Original file line numberDiff line numberDiff line change
@@ -635,9 +635,12 @@ void Object::get_property_list(List<PropertyInfo> *p_list, bool p_reversed) cons
635635
#endif
636636
p_list->push_back(PropertyInfo(Variant::OBJECT, "script", PROPERTY_HINT_RESOURCE_TYPE, "Script", PROPERTY_USAGE_DEFAULT));
637637
}
638-
if (!metadata.empty()) {
639-
p_list->push_back(PropertyInfo(Variant::DICTIONARY, "__meta__", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_NOEDITOR | PROPERTY_USAGE_INTERNAL));
640-
}
638+
639+
#ifdef TOOLS_ENABLED
640+
p_list->push_back(PropertyInfo(Variant::NIL, "Metadata", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_GROUP));
641+
#endif
642+
p_list->push_back(PropertyInfo(Variant::DICTIONARY, "__meta__", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_DEFAULT));
643+
641644
if (script_instance && !p_reversed) {
642645
p_list->push_back(PropertyInfo(Variant::NIL, "Script Variables", PROPERTY_HINT_NONE, String(), PROPERTY_USAGE_CATEGORY));
643646
script_instance->get_property_list(p_list);

editor/animation_track_editor.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class AnimationTrackKeyEdit : public Object {
4646
public:
4747
bool setting;
4848

49-
bool _hide_script_from_inspector() {
49+
bool _hide_object_properties_from_inspector() {
5050
return true;
5151
}
5252

@@ -58,7 +58,7 @@ class AnimationTrackKeyEdit : public Object {
5858

5959
ClassDB::bind_method("_update_obj", &AnimationTrackKeyEdit::_update_obj);
6060
ClassDB::bind_method("_key_ofs_changed", &AnimationTrackKeyEdit::_key_ofs_changed);
61-
ClassDB::bind_method("_hide_script_from_inspector", &AnimationTrackKeyEdit::_hide_script_from_inspector);
61+
ClassDB::bind_method("_hide_object_properties_from_inspector", &AnimationTrackKeyEdit::_hide_object_properties_from_inspector);
6262
ClassDB::bind_method("get_root_path", &AnimationTrackKeyEdit::get_root_path);
6363
ClassDB::bind_method("_dont_undo_redo", &AnimationTrackKeyEdit::_dont_undo_redo);
6464
}

editor/editor_inspector.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -1550,7 +1550,7 @@ void EditorInspector::update_tree() {
15501550
if (p.usage & PROPERTY_USAGE_HIGH_END_GFX && VS::get_singleton()->is_low_end())
15511551
continue; //do not show this property in low end gfx
15521552

1553-
if (p.name == "script" && (hide_script || bool(object->call("_hide_script_from_inspector")))) {
1553+
if ((hide_object_properties || bool(object->call("_hide_object_properties_from_inspector"))) && (p.name == "script" || p.name == "__meta__")) {
15541554
continue;
15551555
}
15561556

@@ -1877,8 +1877,8 @@ void EditorInspector::set_use_doc_hints(bool p_enable) {
18771877
use_doc_hints = p_enable;
18781878
update_tree();
18791879
}
1880-
void EditorInspector::set_hide_script(bool p_hide) {
1881-
hide_script = p_hide;
1880+
void EditorInspector::set_hide_object_properties(bool p_hide) {
1881+
hide_object_properties = p_hide;
18821882
update_tree();
18831883
}
18841884
void EditorInspector::set_use_filter(bool p_use) {
@@ -2318,7 +2318,7 @@ EditorInspector::EditorInspector() {
23182318
set_enable_v_scroll(true);
23192319

23202320
show_categories = false;
2321-
hide_script = true;
2321+
hide_object_properties = true;
23222322
use_doc_hints = false;
23232323
capitalize_paths = true;
23242324
use_filter = false;

editor/editor_inspector.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ class EditorInspector : public ScrollContainer {
272272

273273
LineEdit *search_box;
274274
bool show_categories;
275-
bool hide_script;
275+
bool hide_object_properties;
276276
bool use_doc_hints;
277277
bool capitalize_paths;
278278
bool use_filter;
@@ -360,7 +360,7 @@ class EditorInspector : public ScrollContainer {
360360

361361
void set_show_categories(bool p_show);
362362
void set_use_doc_hints(bool p_enable);
363-
void set_hide_script(bool p_hide);
363+
void set_hide_object_properties(bool p_hide);
364364

365365
void set_use_filter(bool p_use);
366366
void register_text_enter(Node *p_line_edit);

editor/inspector_dock.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ InspectorDock::InspectorDock(EditorNode *p_editor, EditorData &p_editor_data) {
597597
inspector->set_show_categories(true);
598598
inspector->set_v_size_flags(Control::SIZE_EXPAND_FILL);
599599
inspector->set_use_doc_hints(true);
600-
inspector->set_hide_script(false);
600+
inspector->set_hide_object_properties(false);
601601
inspector->set_enable_capitalize_paths(bool(EDITOR_GET("interface/inspector/capitalize_properties")));
602602
inspector->set_use_folding(!bool(EDITOR_GET("interface/inspector/disable_folding")));
603603
inspector->register_text_enter(search);

editor/plugins/tile_set_editor_plugin.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -3369,7 +3369,7 @@ void TilesetEditorContext::_get_property_list(List<PropertyInfo> *p_list) const
33693369

33703370
void TilesetEditorContext::_bind_methods() {
33713371

3372-
ClassDB::bind_method("_hide_script_from_inspector", &TilesetEditorContext::_hide_script_from_inspector);
3372+
ClassDB::bind_method("_hide_object_properties_from_inspector", &TilesetEditorContext::_hide_object_properties_from_inspector);
33733373
}
33743374

33753375
TilesetEditorContext::TilesetEditorContext(TileSetEditor *p_tileset_editor) {

editor/plugins/tile_set_editor_plugin.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ class TilesetEditorContext : public Object {
252252
bool snap_options_visible;
253253

254254
public:
255-
bool _hide_script_from_inspector() { return true; }
255+
bool _hide_object_properties_from_inspector() { return true; }
256256
void set_tileset(const Ref<TileSet> &p_tileset);
257257

258258
private:

0 commit comments

Comments
 (0)