Skip to content

Commit 803d25a

Browse files
authored
Merge pull request #61961 from jtnicholl/anim_lib_type_hints
Fix type hints for AnimationLibrary's signals' arguments
2 parents 4953707 + 3d8e400 commit 803d25a

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

doc/classes/AnimationLibrary.xml

+4-4
Original file line numberDiff line numberDiff line change
@@ -51,18 +51,18 @@
5151
</members>
5252
<signals>
5353
<signal name="animation_added">
54-
<argument index="0" name="name" type="Animation" />
54+
<argument index="0" name="name" type="StringName" />
5555
<description>
5656
</description>
5757
</signal>
5858
<signal name="animation_removed">
59-
<argument index="0" name="name" type="Animation" />
59+
<argument index="0" name="name" type="StringName" />
6060
<description>
6161
</description>
6262
</signal>
6363
<signal name="animation_renamed">
64-
<argument index="0" name="name" type="Animation" />
65-
<argument index="1" name="to_name" type="Animation" />
64+
<argument index="0" name="name" type="StringName" />
65+
<argument index="1" name="to_name" type="StringName" />
6666
<description>
6767
</description>
6868
</signal>

scene/resources/animation_library.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,9 @@ void AnimationLibrary::_bind_methods() {
143143
ClassDB::bind_method(D_METHOD("_get_data"), &AnimationLibrary::_get_data);
144144

145145
ADD_PROPERTY(PropertyInfo(Variant::DICTIONARY, "_data", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_NO_EDITOR), "_set_data", "_get_data");
146-
ADD_SIGNAL(MethodInfo("animation_added", PropertyInfo(Variant::OBJECT, "name", PROPERTY_HINT_RESOURCE_TYPE, "Animation")));
147-
ADD_SIGNAL(MethodInfo("animation_removed", PropertyInfo(Variant::OBJECT, "name", PROPERTY_HINT_RESOURCE_TYPE, "Animation")));
148-
ADD_SIGNAL(MethodInfo("animation_renamed", PropertyInfo(Variant::OBJECT, "name", PROPERTY_HINT_RESOURCE_TYPE, "Animation"), PropertyInfo(Variant::OBJECT, "to_name", PROPERTY_HINT_RESOURCE_TYPE, "Animation")));
146+
ADD_SIGNAL(MethodInfo("animation_added", PropertyInfo(Variant::STRING_NAME, "name")));
147+
ADD_SIGNAL(MethodInfo("animation_removed", PropertyInfo(Variant::STRING_NAME, "name")));
148+
ADD_SIGNAL(MethodInfo("animation_renamed", PropertyInfo(Variant::STRING_NAME, "name"), PropertyInfo(Variant::STRING_NAME, "to_name")));
149149
}
150150
AnimationLibrary::AnimationLibrary() {
151151
}

0 commit comments

Comments
 (0)