Skip to content

Commit ec62978

Browse files
Fix non const animation node process function
1 parent 92e51fc commit ec62978

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

doc/classes/AnimationNode.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
When inheriting from [AnimationRootNode], implement this virtual method to return whether the [param parameter] is read-only. Parameters are custom local memory used for your animation nodes, given a resource can be reused in multiple trees.
6464
</description>
6565
</method>
66-
<method name="_process" qualifiers="virtual const" deprecated="Currently this is mostly useless as there is a lack of many APIs to extend AnimationNode by GDScript. It is planned that a more flexible API using structures will be provided in the future.">
66+
<method name="_process" qualifiers="virtual" deprecated="Currently this is mostly useless as there is a lack of many APIs to extend AnimationNode by GDScript. It is planned that a more flexible API using structures will be provided in the future.">
6767
<return type="float" />
6868
<param index="0" name="time" type="float" />
6969
<param index="1" name="seek" type="bool" />

misc/extension_api_validation/4.3-stable.expected

+7
Original file line numberDiff line numberDiff line change
@@ -95,3 +95,10 @@ Validate extension JSON: Error: Field 'classes/InputMap/methods/add_action/argum
9595

9696
Default deadzone value was changed. No adjustments should be necessary.
9797
Compatibility method registered.
98+
99+
100+
GH-97020
101+
--------
102+
Validate extension JSON: Error: Field 'classes/AnimationNode/methods/_process': is_const changed value in new API, from true to false.
103+
104+
`_process` virtual method fixed to be non const instead.

scene/animation/animation_tree.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ class AnimationNode : public Resource {
151151
GDVIRTUAL1RC(Ref<AnimationNode>, _get_child_by_name, StringName)
152152
GDVIRTUAL1RC(Variant, _get_parameter_default_value, StringName)
153153
GDVIRTUAL1RC(bool, _is_parameter_read_only, StringName)
154-
GDVIRTUAL4RC(double, _process, double, bool, bool, bool)
154+
GDVIRTUAL4R(double, _process, double, bool, bool, bool)
155155
GDVIRTUAL0RC(String, _get_caption)
156156
GDVIRTUAL0RC(bool, _has_filter)
157157

0 commit comments

Comments
 (0)