Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root folder color can be changed if selected in a particular order #100159

Closed
alessand10 opened this issue Dec 8, 2024 · 0 comments · Fixed by #100161
Closed

Root folder color can be changed if selected in a particular order #100159

alessand10 opened this issue Dec 8, 2024 · 0 comments · Fixed by #100161

Comments

@alessand10
Copy link
Contributor

alessand10 commented Dec 8, 2024

Tested versions

Tested in v4.4.dev.custom_build [aa8d9b8]

System information

Godot v4.4.dev (aa8d9b8) - Windows 10.0.22631 - Multi-window, 1 monitor - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2070 (NVIDIA; 32.0.15.6094) - 12th Gen Intel(R) Core(TM) i7-12700KF (20 threads)

Issue description

It appears that the file/folder multi-selection logic is not working correctly. When I select multiple folders (including the root folder), then depending on the order of selection, I can either set the root folder's color or I can't. From inspecting the file system logic, it appears that I should not be able to change the root folder's color regardless of selection order.

Menu when root is not the first folder selected:
Image

Menu when root is the first folder selected:
Image

This issue appears related to #99932

Steps to reproduce

  1. Open any project and create a folder under the root folder in the file system.
  2. Select the root folder then multi-select your created sub folder (you should not see an option to set the file color in the menu after right clicking)
  3. Select only the sub folder then multi-select your root folder (you should see an to set the file color in the menu after right clicking)

Minimal reproduction project (MRP)

broken_filesystem.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants