Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cant disable this error "causing RenderingServer synchronizations on every frame. This significantly affects performance." #100411

Closed
PeterMarques opened this issue Dec 14, 2024 · 1 comment

Comments

@PeterMarques
Copy link

PeterMarques commented Dec 14, 2024

The error message in question no longer exists in 4.3.beta1 (likely as the result of refactoring such as #84976). The issue should be (indirectly) fixed there already; can someone test?

The warning message will be replaced with this one:

#define MAIN_THREAD_SYNC_WARN WARN_PRINT("Call to " + String(__FUNCTION__) + " causing RenderingServer synchronizations on every frame. This significantly affects performance.");

Originally posted by @clayjohn in #83046

I need to iterate over several viewports every frame:

for key in vpdic.keys():
var ima = vpdic[key].get_texture().get_image()

So this error naturaly triggers;

How to disable as its buid-up slows and clutter the logger.

(Only happens if rendering/driver/threads/thread_model is set to multi-threaded)

@PeterMarques PeterMarques changed the title Cant disable this error Cant disable this error "causing RenderingServer synchronizations on every frame. This significantly affects performance." Dec 14, 2024
@clayjohn
Copy link
Member

In this case you should disable the multi threaded thread model. The warning is correctly showing you that you are synchronizing the rendering thread with the main thread every frame, so you get no benefit from multithreading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants