keys_pressed does not seem to accurately reflect the keys being pressed on Wayland

[pcvonz]

Tested versions

• Reproducible in 75ce426 & 4.3

System information

Manjaro Gnome Wayland

Issue description

Keys pressed seems to not be reset sometimes.

I noticed this issue because the method is_anything_pressed returns true when I was trying out the new tooltip feature, even it should be returning false.

godot/core/input/input.cpp

Line 298 in 75ce426

if (!keys_pressed.is_empty() || !joy_buttons_pressed.is_empty() || !mouse_button_mask.is_empty()) {

Steps to reproduce

It seems like I can trigger it fairly consistently by searching and then opening a file in the filesystem browser.

Screencast.From.2024-12-28.12-58-29.mp4

Minimal reproduction project (MRP)

This is just a simple project with a tool script that calls is_anything_pressed
project.zip

[pcvonz]

Looking into this further.. It seems to be reproducible by:

1. Pressing any key
2. Pressing shift
3. Releasing both keys

Some logging of the bug (print statements put in the if and else block of:

godot/core/input/input.cpp

Line 694 in 2582793

keys_pressed.insert(k->get_keycode());

INSERT: Minus 45
INSERT: Shift 4194325
ERASE: Shift+UnderScore 95
ERASE: Shift+Shift 4194325

[pcvonz]

I don't think this is a wayland issue. I have a PR open that moves away from using the keys_pressed set to detect if a key is pressed here. I'm not sure what the proper solution is for this issue. Maybe deriving the the set of keys pressed from physical_keys_pressed instead of attempting to keep track of them?

[Riteo]

Hi @pcvonz, thanks for the report and for investigating! I did some further research and it looks like the issue actually does actually come from the Wayland backend. As you found out, the keycodes come "composed" with the various modifier keys, which should not happen (you can see that when using the X11 display driver). I just pushed a PR with a proposed fix over at #101848.