Editor Rendering is bugged with PR #90644 - Add CollisionShape3D custom debug colors

[RevoluPowered]

Tested versions

• Not reproducible in dev 3. (f4af820)
• Reproducible in beta 1 (d33da79)
• Reproducible in master (f1c0b5b)
• Bug Introduced in (0fc082e)
  I bisected to the commit:

0fc082e1ee3af5bb6a4b52f85756d24dc02b230f is the first bad commit
commit 0fc082e1ee3af5bb6a4b52f85756d24dc02b230f (HEAD)

System information

MacOS - Sonoma 14.4.1 - 16 GB - M1 Silicon

Issue description

The debug colour PR results in geometry having strange boxes on it.

Without the PR the geometry works fine, and doesn't have the boxes.

Happens on metal and on moltenvk backends.

Steps to reproduce

1. open my test project
2. open main_scene.tscn (ignore missing dependencies... open anyway)
3. move mouse around select the root node
4. flickering should be present as you wasd move the camera on the objects

unsure if reproducible on windows/linux

You can test-revert the PR using my branch here:
https://github.com/RevoluPowered/godot/tree/revert-color-pr

Minimal reproduction project (MRP)

mrp-extract-inside-folder.zip

[skyace65]

My computer specs: Godot v4.4.beta1 - Windows 10 (build 19045) - Multi-window, 1 monitor - Vulkan (Forward+) - dedicated AMD Radeon RX 6950 XT (Advanced Micro Devices, Inc.; 32.0.12033.1030) - AMD Ryzen 7 9700X 8-Core Processor (16 threads)

I tested your reproduction project on Beta 1, when I open it I'm getting a message about missing stuff from Qodot. In the scene I'm not seeing boxes but I am seeing this flickering behavior on some specific walls, not all of them though, this one looks like the exact same wall from your picture.

I'm also attaching a video of the issue happening

BugTestReplication.zip

I was unable to use the branch you made to test if reverting the PR fixed the issue, the build is failing for me.

[RevoluPowered]

I was unable to use the branch you made to test if reverting the PR fixed the issue, the build is failing for me.

Fixed, please try again my bad.

[fire]

Same as #99184 ?

[RevoluPowered]

Same as #99184 ?

I don't know for sure, it looks similar but unsure if directly related.

The squares in the issue report do not directly look like z fighting but it is present on some of them.

[RevoluPowered]

@BattyBovine could you take a look possibly?

[BattyBovine]

This definitely looks like Z-fighting to me, and is probably related to #99184. It seems like the fix for this is #100211, which will draw gizmos with an offset from the mesh to prevent this from happening.

[RevoluPowered]

This definitely looks like Z-fighting to me, and is probably related to #99184. It seems like the fix for this is #100211, which will draw gizmos with an offset from the mesh to prevent this from happening.

OK I'll take a look at @Calinou's PR and give it a test thank you; I'll ask the other PR to be merged if its in a good spot if it does resolve the problem.

[Calinou]

Thanks for the report! Consolidating in #99184, as this is due to the same cause.

Z-fighting on TBDR GPUs (mobile/Apple GPUs) takes the form of these squares, so it looks different from standard Z-fighting on desktop GPUs, but it's the exact same cause.

[RevoluPowered]

Thanks for the report! Consolidating in #99184, as this is due to the same cause.

Z-fighting on TBDR GPUs (mobile/Apple GPUs) takes the form of these squares, so it looks different from standard Z-fighting on desktop GPUs, but it's the exact same cause.

Appreciate your help as always, thank you! I think we could possibly put something in the documentation regarding z-fighting on apple vs nv/amd :)

[RevoluPowered]

Confirming that if you run into this issue, it is resolved by #100211