Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG project icon is no longer displayed correctly since 4.4.beta2 #102721

Closed
Mister-Karate opened this issue Feb 11, 2025 · 12 comments · Fixed by #102781
Closed

SVG project icon is no longer displayed correctly since 4.4.beta2 #102721

Mister-Karate opened this issue Feb 11, 2025 · 12 comments · Fixed by #102781

Comments

@Mister-Karate
Copy link

Mister-Karate commented Feb 11, 2025

Tested versions

Godot 4.4 beta 3

System information

windows 10

Issue description

When selecting a project in Godot Engine 4.4 Beta 3, no SVG icons are displayed (just empty space). This issue started in version 4.4 Beta 2 and persists in Beta 3. The affected icons were created in Inkscape (version 1.4) and worked correctly in previous versions of Godot (e.g. 4.3 or 4.4 Beta 1).

Steps to reproduce

When selecting a project in Godot Engine 4.4 Beta 3

Minimal reproduction project (MRP)

Image

@Calinou
Copy link
Member

Calinou commented Feb 11, 2025

Please upload a minimal reproduction project1 to make this easier to troubleshoot.

Footnotes

  1. A small Godot project which reproduces the issue, with no unnecessary files included. Be sure to not include the .godot folder in the archive (but keep project.godot).

    Drag and drop a ZIP archive to upload it. Do not select another field until the project is done uploading.

    Note for C# users: If your issue is not C#-specific, please upload a minimal reproduction project written in GDScript. This will make it easier for contributors to reproduce the issue locally as not everyone has a Mono setup available.

@Calinou Calinou changed the title GODOT 4.4 BETA 3 PROJECT ICON SVG project icon is no longer displayed correctly since 4.4.beta2 Feb 11, 2025
@akien-mga
Copy link
Member

akien-mga commented Feb 11, 2025

I can't reproduce it when creating new projects which use icon.svg by default. So this is likely specific to the SVG icons you're using; could you share some of them?

We did update ThorVG in 4.4.beta2 (#101347) so that might indeed be a regression from our SVG loading library.

@akien-mga akien-mga added this to the 4.4 milestone Feb 11, 2025
@akien-mga akien-mga self-assigned this Feb 11, 2025
@akien-mga akien-mga moved this from Unassessed to Bad in 4.x Release Blockers Feb 11, 2025
@Meorge
Copy link
Contributor

Meorge commented Feb 12, 2025

I also tried creating a simple SVG icon in Inkscape 1.4 and exporting it with the types:

  • Inkscape SVG (*.svg)
  • Plain SVG (*.svg)
  • Optimized SVG (*.svg) with default settings

All of these appeared to display correctly in the Project Manager.

@Mister-Karate
Copy link
Author

Mister-Karate commented Feb 12, 2025

The process I do is to create an icon in .PNG, I still use the paint XP program, then I open that image in Inkscape 1.4 and without vectorizing it I just save it as .SVG, this was displayed correctly before the godot 4.2 version.

@akien-mga
Copy link
Member

It would be really helpful if you shared one such SVG (you can zip it and drag and drop to GitHub to upload).

@Mister-Karate
Copy link
Author

ICON+PAINTXP.zip

@Meorge
Copy link
Contributor

Meorge commented Feb 12, 2025

Looks like I was just able to reproduce it:

Image

Here's the icon.svg I used:
Image

@Mister-Karate
Copy link
Author

woow, it also happened to you using the process of creating an icon in png in paint XP and then saving it as SVG in Inkscape 1.4 without vectorizing it, right?

@Meorge
Copy link
Contributor

Meorge commented Feb 12, 2025

Yep! Although in my case, the PNG was made with Affinity Designer on the iPad. But I tried importing it into Inkscape as an embedded PNG and saving it as an "Inkscape SVG" without vectorizing the PNG, and the icon wouldn't display in the Project Manager.

On c11863c (before #101347 was merged), the icon does appear:

Image

On df7572f (where #101347 was merged), the icon doesn't appear:

Image

So it does indeed appear to be a regression from ThorVG.

@akien-mga
Copy link
Member

Thanks both, I'll look into it.

@Mister-Karate
Copy link
Author

Mister-Karate commented Feb 12, 2025

Congratulations, you do a great job as a team! I wish you the best of luck. The Godot engine is improved by people like you two who love making dreams come true.

@bruvzg
Copy link
Member

bruvzg commented Feb 12, 2025

Seems like it's missing THORVG_FILE_IO_SUPPORT define in SVG module (new option in the last update), which disables embedded PNG loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Bad
Development

Successfully merging a pull request may close this issue.

6 participants