Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP extremely slow when certain scene has instance of another scene #102929

Closed
rcorre opened this issue Feb 16, 2025 · 4 comments
Closed

LSP extremely slow when certain scene has instance of another scene #102929

rcorre opened this issue Feb 16, 2025 · 4 comments

Comments

@rcorre
Copy link
Contributor

rcorre commented Feb 16, 2025

Tested versions

Reproducible in: 4.3.1.rc.custom_build.90f21a35c

System information

Godot v4.3.1.rc (90f21a3) - Arch Linux #1 SMP PREEMPT_DYNAMIC Sat, 08 Feb 2025 18:54:55 +0000 - Wayland - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 (nvidia; 570.86.16) - AMD Ryzen 5 5600X 6-Core Processor (12 Threads)

Issue description

When editing Player.gd in my project, the LSP is extremely slow. It takes several seconds for diagnostics or completions to update. If I remove the ThirdPersonModel node from Player.tscn, the LSP performance drastically improves. I'm using the LSP via the helix editor.

Before:
asciicast

After:
asciicast

Steps to reproduce

  1. Open Player.gd in an external editor using the LSP.
  2. In _ready, try typing rollback_
  3. Wait for completions to appear, it takes several seconds.
  4. Delete ThirdPersonModel from Player.tscn
  5. Note that the LSP is now much faster

Minimal reproduction project (MRP)

I spent a while trying to minimize my project. It could probably be taken further, but this is relatively minimal.

example.zip

@ghost
Copy link

ghost commented Feb 16, 2025

Cannot reproduce when using VSCode. The LSP responds instantly, even without deleting ThirdPersonModel.

Godot v4.3.stable
Manjaro Linux #1 SMP PREEMPT_RT Thu Jan  9 22:11:24 UTC 2025
X11 - Vulkan (Forward+)
dedicated NVIDIA GeForce GTX 1050 Ti (nvidia; 550.144.03) - AMD Ryzen 7 2700 Eight-Core Processor (16 Threads)

@HolonProduction
Copy link
Member

Might be a duplicate of #100934

Could you check, how the behavior changes, depending on if the scene is open in the Godot editor.

@rcorre
Copy link
Contributor Author

rcorre commented Feb 17, 2025

Wow, I spent a bunch of time trying to get an MRP last night, and was confident I could still repro. Now I can't repro, even on my original, non-minimized project. If it comes up again, I'll try closing the scene and running with #101091.

@rcorre
Copy link
Contributor Author

rcorre commented Feb 19, 2025

Ok, I can repro again, and closing the scene does not help. However, #101091 does seem to resolve the issue!
I think this can be closed as a dupe of #100934. Thanks!

@rcorre rcorre closed this as completed Feb 19, 2025
@github-project-automation github-project-automation bot moved this from For team assessment to Done in GDScript Issue Triage Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants