Rename node with space key press not working

[Tiny-can-WZB]

Tested versions

-Reproducible in Godot-4.4-beta2 and above
-Not reproducible in Godot-4.4-beta1 and below

System information

Windows11 - Godot-4.4-bata2 and above - Vulken(Forward+)

Issue description

Before Godot-4.4-bata1, when a node is selected(highlighted) in the editor, pressing space key in a keyboard will trigger the renaming of the node, however this no longer works in 4.4-bata2 and above, doing so seems to simply deselect the highlighted node.

Steps to reproduce

• Create a new scene with any node
• Select any node in the scene tree with mouse
• Press the Space key when the node is highlighted

Minimal reproduction project (MRP)

• Nothing

[BrotherShort]

The bug originates from merge #101842 .
Pressing space key belongs to "ui_accept" action and "ui_select" action.
Before #101842, the tree control code processed "ui_accept" action first, then "ui_select" action. So Pressing space key would go into the if statement dealing with "ui_accept" action, and started rename.
#101842 exchanged "ui_accept" action and "ui_select" action. So Pressing space key will go into the if statement dealing with "ui_select" action, and never start rename.

[Tiny-can-WZB]

The bug originates from merge #101842 . Pressing space key belongs to "ui_accept" action and "ui_select" action. Before #101842, the tree control code processed "ui_accept" action first, then "ui_select" action. So Pressing space key would go into the if statement dealing with "ui_accept" action, and started rename. #101842 exchanged "ui_accept" action and "ui_select" action. So Pressing space key will go into the if statement dealing with "ui_select" action, and never start rename.

So its intended to work this way?

[akien-mga]

CC @havi05 @KoBeWi

It seems indeed like it's intentional, but I see how it can be an issue for people used to this workflow.

[havi05]

Currently, I don't have an idea how to support both actions using the same key.

I changed the order of if statements, because previously it wasn't possible to select an item in a tree by pressing a key, but ui_accept has another key mapped (Enter) so at least there would be a way to trigger both actions with the default key mapping.

As a quick workaround, you could change the default key mapping for ui_select in the editor settings.

[KoBeWi]

As I mentioned in the PR, it fixed an issue for default control scheme (previously you couldn't use ui_select because of overlap). Alternative was remapping either action to a different key, but it's less invasive to change behavior of one node than all of them.

You can still rename nodes with Enter, or as mentioned above, change ui_select to something else. Unless there is a solution that would solve both issues, having correct behavior with default scheme takes priority, so it's not going to be changed.