Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoxelGI has a visible effect on the scene when energy = 0 #104100

Closed
JustASquid opened this issue Mar 14, 2025 · 3 comments
Closed

VoxelGI has a visible effect on the scene when energy = 0 #104100

JustASquid opened this issue Mar 14, 2025 · 3 comments

Comments

@JustASquid
Copy link

Tested versions

4.4-stable

System information

Godot v4.4.stable.mono - Windows 10 (build 19045) - Multi-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (NVIDIA; 32.0.15.6094) - AMD Ryzen 9 7950X 16-Core Processor (32 threads)

Issue description

VoxelGI has a visual impact on the scene when energy=0.

This is an issue as I want to fade out my voxelGI lighting under certain circumstances. When the voxelGI is fully faded out, setting it to invisible is important to reduce performance impact on the scene. But right now this causes a visual hitch as it's not possible to smoothly transition between voxelGI visible -> voxelGI invisible.

Steps to reproduce

Whjen a voxelGI node in a scene has energy=0, the scene still looks different depending on if the voxelGI node is visible or invisible.

Enabled:

Image

Disabled:

Image

Minimal reproduction project (MRP)

voxelgi_energy_issue_mrp.zip

@Calinou
Copy link
Member

Calinou commented Mar 15, 2025

This is done by design. Reducing VoxelGI energy reduces the brightness of its global illumination, but it does not blend between the fallback environment lighting and VoxelGI. Otherwise, you wouldn't be able to reduce the VoxelGI energy without introducing additional light leaking (since environment sky lighting is global).

Blending VoxelGI with other GI sources requires a dedicated implementation, ideally one that is localized similar to ReflectionProbe blend distance.

This is an issue as I want to fade out my voxelGI lighting under certain circumstances.

Out of curiosity, what circumstances are you looking to disable VoxelGI under?

@JustASquid
Copy link
Author

@Calinou Basically I have an outdoor scene with 2 lighting situations, "daytime" and "nighttime". During the day I don't need voxelGI as the sunlight is sufficient. During the night, things like lights etc. become much more relevant and so GI reflections etc. are important.

I suppose I could just have voxelGI on all the time, but I was hoping to optimize slightly by disabling it during the day. Anyway your explanation is sufficient that this is not a bug, so feel free to close the issue.

@Calinou Calinou closed this as completed Mar 17, 2025
@Calinou
Copy link
Member

Calinou commented Mar 17, 2025

Closing per the above comment. Feel free to open a proposal if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants