Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move material attributes from shader declaration #21105

Closed
kosz78 opened this issue Aug 17, 2018 · 3 comments
Closed

Move material attributes from shader declaration #21105

kosz78 opened this issue Aug 17, 2018 · 3 comments

Comments

@kosz78
Copy link
Contributor

kosz78 commented Aug 17, 2018

I have some proposal for shader material optimization.
Currently material properties such as blend_xxx, depth_xxx and cull_xxx are declared in shader code.
It is required create a lot of similar shaders with different combination of these properties that affect on number of shaders and compilation time.
If these properties will be moved to material properties it will significant reduce amount of shaders and reduce total compilation time.

@karroffel
Copy link
Contributor

I am implementing stencil buffer support right now in a fork, for that I want to be able to set the reference values and the mask values via a script without recompiling the shaders, so I am hardcoding a system like this for my usecase right now.

I agree that such a material/shader-wide parameter system would be better than hardcoding the values into the shader source code.

@akien-mga
Copy link
Member

Moving to the 3.2 milestone where most new rendering features will be considered, it's too late for 3.1.

@akien-mga akien-mga modified the milestones: 3.1, 3.2 Sep 15, 2018
@akien-mga akien-mga modified the milestones: 3.2, 4.0 Nov 14, 2019
@clayjohn
Copy link
Member

Feature and improvement proposals for the Godot Engine are now being discussed and reviewed in a dedicated Godot Improvement Proposals (GIP) (godotengine/godot-proposals) issue tracker. The GIP tracker has a detailed issue template designed so that proposals include all the relevant information to start a productive discussion and help the community assess the validity of the proposal for the engine.

The main (godotengine/godot) tracker is now solely dedicated to bug reports and Pull Requests, enabling contributors to have a better focus on bug fixing work. Therefore, we are now closing all older feature proposals on the main issue tracker.

If you are interested in this feature proposal, please open a new proposal on the GIP tracker following the given issue template (after checking that it doesn't exist already). Be sure to reference this closed issue if it includes any relevant discussion (which you are also encouraged to summarize in the new proposal). Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants