Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destination directory to load_resource_pack #25815

Closed
mnn opened this issue Feb 12, 2019 · 3 comments · Fixed by #35261
Closed

Add destination directory to load_resource_pack #25815

mnn opened this issue Feb 12, 2019 · 3 comments · Fixed by #35261

Comments

@mnn
Copy link

mnn commented Feb 12, 2019

Godot version: 3.1.beta3.mono

Currently bool load_resource_pack ( String pack ) loads everything and then dumps it directly in res://. I would like to have an option to specify to what (virtual) directory contents of pck will be loaded. It shouldn't be a breaking change, since the new parameter could be optional.

For example after running this:

ProjectSettings.load_resource_pack("mods/mod1.pck", "mod1")

contents of mod1.pck would be accessible in res://mod1/.

@mnn
Copy link
Author

mnn commented Mar 2, 2019

Is this a desired feature, has it potential to be merged - should I try implementing it? (Operative word try, since I don't know much about engine internals nor C++.)

If not, I could explore other approaches to my problem, e.g. reading files' paths from pck and rejecting (not loading) invalid mods.

@akien-mga
Copy link
Member

Reopening as #35261 was reverted, as it's not so useful without a proper remapping of dependency paths.

@akien-mga akien-mga reopened this Apr 20, 2020
@akien-mga
Copy link
Member

This should likely be reopened as a more detailed proposal on godot-proposals, with a suggestion on how to handle remapping dependencies to the new path.

See also godotengine/godot-proposals#2689 which is a related proposal (though it doesn't seem to cater to loading in subpaths specifically).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants