Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_lower() method bug in Russian (cyrillic) #26744

Closed
exe2k opened this issue Mar 7, 2019 · 1 comment · Fixed by #26760
Closed

to_lower() method bug in Russian (cyrillic) #26744

exe2k opened this issue Mar 7, 2019 · 1 comment · Fixed by #26760
Milestone

Comments

@exe2k
Copy link

exe2k commented Mar 7, 2019

Godot version:
3.1 beta 11

OS/device including version:
Windows 10 x64 intel i5 10gb RAM GF 660 GTX

Issue description:
to_lower() doesn't work for russian as it expected. It left almost half of letters in upper case.

Steps to reproduce:
var caps = "АБВГДЕЁЖЗИЙКЛМНОПРСТУФХЦЧШЩЪЫЬЭЮЯ" print(caps.to_lower())

the result will be:

абвгдеЁжзийклмнопрстуФХЦЧШЩЪЫЬЭЮЯ
as you can see the letter "Ё" and from "Ф" to "Я" are yet capitalized.

@akien-mga
Copy link
Member

The relevant code is in https://github.com/godotengine/godot/blob/master/core/ucaps.h
Might need extra entries for the Cyrillic letters which don't match a Latin letter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants