Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Changing Half Resolution doesn't update immediately #49082

Closed
foxydevloper opened this issue May 25, 2021 · 2 comments · Fixed by #61649
Closed

Vulkan: Changing Half Resolution doesn't update immediately #49082

foxydevloper opened this issue May 25, 2021 · 2 comments · Fixed by #61649

Comments

@foxydevloper
Copy link
Contributor

foxydevloper commented May 25, 2021

Godot version:
v4.0.dev.custom_build.b6f381475

OS/device including version:
Windows 10
Vulkan

Issue description:
Changing Half Resolution doesn't immediately update. It only updates when you change a different setting such as anti aliasing.

Steps to reproduce:
Enable or disable Half Resolution, it won't do anything, but if you enter project settings and change anti aliasing, it will update the Half Resolution to what you had selected

2021-05-25_16-37-18.mp4

Minimal reproduction project:
Can test it on any 3D scene

@Calinou Calinou added this to the 4.0 milestone May 25, 2021
@Calinou Calinou changed the title Changing Half Resolution doesn't update immediately Vulkan: Changing Half Resolution doesn't update immediately May 25, 2021
@foxydevloper
Copy link
Contributor Author

foxydevloper commented Jul 20, 2021

Was looking at this and found out more about this bug, for some reason if you change Half Resolution and open up a scene it resets Half Resolution back to what it was previously. It seems like changing Half Resolution doesn't even save at all, the only way to for it to save is to change anti aliasing (or some other rendering setting)

2021-07-20_17-47-08.mp4

@Calinou
Copy link
Member

Calinou commented Oct 16, 2021

Now that #51870 was merged, the Half Resolution option needs to be modified to use built-in 3D render scaling instead of Viewport's Shrink property. This will also fix #33937 at the same time 🙂

@KoBeWi KoBeWi moved this to To Assess in 4.x Priority Issues Jun 2, 2022
@KoBeWi KoBeWi moved this from To Assess to Todo in 4.x Priority Issues Jun 2, 2022
@KoBeWi KoBeWi moved this from Todo to In Progress in 4.x Priority Issues Jun 3, 2022
Repository owner moved this from In Progress to Done in 4.x Priority Issues Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants