Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystem drag and drop can easily lead to missing dependencies issues #5684

Closed
jaydonteh opened this issue Jul 14, 2016 · 14 comments
Closed

Comments

@jaydonteh
Copy link

Windows 10 - Godot 2.1 :

fileSystem usability:
After accidental moving of folders using the drag & drop feature from the fileSystem, along with a manual correction to re-parent my folders will not revert their new paths and cause missing dependencies issues. Having me needed to correct all my scripts, assets and scenes that got involved prior to moving.

Steps to reproduce:
Move folders into folders using drag & drop from the fileSystem; folders that contain assets that were attached to scenes.

Suggestion:
Alert user with a message when moving a folder that contain assets that were attached to node/scenes, changing them will cause missing dependencies, even manually reverting any changes.

@akien-mga akien-mga added this to the 2.1 milestone Jul 14, 2016
@akien-mga akien-mga changed the title fileSystem issues FileSystem drag and drop can easily lead to missing dependencies issues Jul 14, 2016
@vnen
Copy link
Member

vnen commented Jul 14, 2016

Did you do this all via the FileSystem dock, or did you correct using the OS file explorer? AFAIK any change you do in the FileSystem dock will update the references in the owners. So if you reverted through the dock it should rearrange again the dependencies (and if it's not doing it, it's a bug indeed).

If you try to delete a file it warns of the dependency breakage, maybe it should warn too if you're moving files with owners.

@jaydonteh
Copy link
Author

All has been done through the FileSystem, indeed it never rearrange again and cause dependencies error whenever trying to open the affected scenes.

@reduz
Copy link
Member

reduz commented Jul 19, 2016

moving files in theory rearranges dependencies automatically, maybe it's broken?

@akien-mga akien-mga modified the milestones: 2.2, 2.1 Jul 27, 2016
@akien-mga
Copy link
Member

I've played a bit with the FileSystem dock and could not reproduce the issue, though I did notice some bugs (like moving a folder inside another one, and then it won't let you move it back to res://, saying it can't move itself to its current location - though the error is wrong). Nothing critical for the imminent 2.1 release though, but it could be fixed in a future update when the bug has been narrowed down more precisely.

@akien-mga akien-mga modified the milestones: 2.2, 2.1 Jul 31, 2016
@bojidar-bg
Copy link
Contributor

Pretty ping, can this be reproduced, and if so, how? 😃

@Zylann
Copy link
Contributor

Zylann commented Apr 17, 2017

@akien-mga akien-mga modified the milestones: 3.0, 2.2 Aug 8, 2017
@akien-mga
Copy link
Member

Is this still valid in the current master branch?

@Zireael07
Copy link
Contributor

I don't know if dragging a folder causes this, but I've had this problem after I moved a font to a new subfolder, Godot couldn't find it.

@vnen
Copy link
Member

vnen commented Aug 8, 2017

It's worse on master because the dependency checker is not working at all (#9685)

@ghost
Copy link

ghost commented Sep 22, 2017

I may have found out how to reproduce this issue. If a project has the following folders:

res://
    folder 1/
    folder 2/
        file

Then we use the folder tree to drag "folder 2" into "folder 1". The path to file is now res://folder 1/folder 2/file but the dependencies are renamed to res://folder 1/file.

@HummusSamurai
Copy link
Contributor

Possibly fixed by #11428

@HummusSamurai
Copy link
Contributor

Fixed by #13384?

@akien-mga
Copy link
Member

Probably fixed or mitigated by the above yes. Please file a new issue if a similar bug is still reproducible in the master branch.

@ghost
Copy link

ghost commented Apr 5, 2018

v3.0.2 move tscn file into a folder using dock, can't save. google the problem, seems i can "save a"s but i am not sure how to replace original with new. anyway above says its fixed. i have a problem moving with drag/drop and the "move to" right click option. causes crash to desk top most times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants