Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent capitalization of default scene file names #57768

Closed
jmdejong opened this issue Feb 7, 2022 · 7 comments · Fixed by #65561
Closed

Inconsistent capitalization of default scene file names #57768

jmdejong opened this issue Feb 7, 2022 · 7 comments · Fixed by #65561

Comments

@jmdejong
Copy link

jmdejong commented Feb 7, 2022

Godot version

Godot_v4.0-alpha1_linux.64

System information

recently updated arch linux

Issue description

When saving a new scene for the first time the default name (without extension) is the name of the root node of that scene but starting with a lowercase letter (even when the root node starts with an uppercase letter).

When saving a branch as a scene and the root of that branch starts with an uppercase letter, the default filename is the name of that branch root as it is, so with an uppercase letter.

I would expect the proposed default filename to be more consistent

Steps to reproduce

  • Create a new project
  • Create a root node called Main
  • Save this scene. It will show main.tscn as default filename
  • Create a child node called Player
  • Save the Player branch as a scene. It will show Player.tscn as default filename.

Minimal reproduction project

No response

@Calinou
Copy link
Member

Calinou commented Feb 7, 2022

cc @KoBeWi

Note that #41991 addresses this for scripts, but not for scenes.

@KoBeWi
Copy link
Member

KoBeWi commented Feb 8, 2022

The option to change default casing was added in #52597
Seems like it's just not applied in all cases.

@keptsecret
Copy link
Contributor

Hi, I'm new and I'd like to try working on this.
I've had a look and it looks like the enum used for the cases is private in editor_node.h.
Would making it public be a good idea?

@Calinou
Copy link
Member

Calinou commented Feb 9, 2022

Would making it public be a good idea?

Making the enum public sounds fine to fine.

@KoBeWi
Copy link
Member

KoBeWi commented Feb 9, 2022

If making it public is really necessary then yes.

@dmaz
Copy link
Contributor

dmaz commented Mar 22, 2022

It would be nice that while fixing this you could also make it respect the choice in Project Settings... master currently doesn't and just defaults to snake case even if you choose one of the other 2 options

@ryburnj
Copy link
Contributor

ryburnj commented Sep 6, 2022

Hey, new to the scene and I'm just trying to understand.
In keeping with what's outlined in the docs, we want ALL scene tree nodes' file names to be snake case?
Also keen to give this issue a shot!

Repository owner moved this from In Progress to Done in 4.x Priority Issues Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
6 participants