Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selection in Editor Help is not accurate #64292

Closed
KoBeWi opened this issue Aug 11, 2022 · 3 comments · Fixed by #71742
Closed

Selection in Editor Help is not accurate #64292

KoBeWi opened this issue Aug 11, 2022 · 3 comments · Fixed by #71742
Labels
bug confirmed topic:editor usability
Milestone
4.1

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Aug 11, 2022 •
edited
Loading

Godot version

67d4015

System information

Windows 10 x64

Issue description

godot_nkBHH0s3oN
It's off by 1 character.

EDIT:
Actually it only happens in code blocks.

Steps to reproduce

  1. Open some help page
  2. Try to select text in a code block

Minimal reproduction project

No response
@KoBeWi KoBeWi added this to the 4.0 milestone Aug 11, 2022
@KoBeWi KoBeWi removed the regression label Aug 11, 2022
@KoBeWi KoBeWi moved this from To Assess to Todo in 4.x Priority Issues Aug 11, 2022
@KoBeWi KoBeWi moved this to To Assess in 4.x Priority Issues Aug 11, 2022
@Calinou
Copy link
Member

Calinou commented Aug 11, 2022 •
edited
Loading

Selecting text within tables likely has some issues. In master, code blocks are located within a table with 1 row and 1 column to add padding on the background (and make the background span the entire line, as opposed to [bgcolor]).

@YuriSizov
Copy link
Contributor

Is this still an issue? There have been some fixes to RTL and tables.

@KoBeWi
Copy link
Member Author

KoBeWi commented Jan 12, 2023

Yes.

@KoBeWi KoBeWi mentioned this issue Jan 20, 2023
Merged
@akien-mga akien-mga modified the milestones: 4.0, 4.1 Feb 17, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in 4.x Priority Issues Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed topic:editor usability
Projects
4.x Priority Issues
Archived in project
Milestone
4.1
Development

Successfully merging a pull request may close this issue.

Fix RichTextLabel wrong selection offset in padded table cell. Koyper/godot
4 participants
@Calinou @KoBeWi @akien-mga @YuriSizov