DisplayServer.WindowSetVsyncMode() causes crash

[stephen-soul]

Godot version

v4.0.alpha.mono.custom_build [e7a0a97]

System information

EndeavourOS Linux

Issue description

I've observed odd behaviour related to calling DisplayServer.WindowSetVsyncMode(DisplayServer.VSyncMode.Enabled);. This seemingly works as intended if not done through a button. I'll attach a project using a toggle button but a similar behaviour is found with a MenuButton. Calling this function through the _Ready function seems to launch without crashing, whereas setting this through causes the below image, or it causes the screen to freeze, or the game to just crash.

The editor returns this error

E 0:00:01:0859   void Godot.DelegateUtils.InvokeWithVariantArgs(IntPtr , Godot.NativeInterop.godot_variant** , UInt32 , Godot.NativeInterop.godot_variant* ): Condition "swapchainImageCount != sp_image_count" is true. Returning: ERR_BUG
  <C++ Source>   drivers/vulkan/vulkan_context.cpp:1756 @ _update_swap_chain()
  <Stack Trace>  Godot.NativeInterop.NativeFuncs.generated.cs:324 @ void Godot.NativeInterop.NativeFuncs.godotsharp_method_bind_ptrcall(IntPtr , IntPtr , System.Void** , System.Void* )()
                 NativeCalls.cs:548 @ void Godot.NativeCalls.godot_icall_2_62(IntPtr , IntPtr , Int32 , Int32 )()
                 DisplayServer.cs:1716 @ void Godot.DisplayServer.WindowSetVsyncMode(Godot.DisplayServer+VSyncMode , Int32 )()
                 CheckButtonVsync.cs:14 @ void CheckButtonVsync.OnToggled(Boolean )()
                 :0 @ System.Object System.RuntimeMethodHandle.InvokeMethod(System.Object , System.Span`1[System.Object]& , System.Signature , Boolean , Boolean )()
                 :0 @ System.Object System.Reflection.RuntimeMethodInfo.Invoke(System.Object , System.Reflection.BindingFlags , System.Reflection.Binder , System.Object[] , System.Globalization.CultureInfo )()
                 :0 @ System.Object System.Delegate.DynamicInvokeImpl(System.Object[] )()
                 :0 @ System.Object System.Delegate.DynamicInvoke(System.Object[] )()
                 DelegateUtils.cs:57 @ void Godot.DelegateUtils.InvokeWithVariantArgs(IntPtr , Godot.NativeInterop.godot_variant** , UInt32 , Godot.NativeInterop.godot_variant* )()

Steps to reproduce

• Open the attached project
• Run the project
• Toggle the Toggle Button.
• Observe 1 of 3 noted problematic scenarios

Minimal reproduction project

Vsync_crash.zip

[Calinou]

Can you reproduce this in a GDScript project? This is probably not C#-related, but just to make sure.

[stephen-soul]

I've tested in v4.0.alpha.custom_build [b6d102c] (another build I had that was non-mono. I can try another build if required) and observed the same behaviour with GDScript, as suspected.
vsync_gdscript.zip

[BluesM18A1]

I was about to open a new issue about this but my experience was slightly different. In my case it only froze with that garbled screen if I set it to mailbox mode, or if the project settings started in mailbox mode and changed to something else.
In my testing, it does not matter if this function is called at ready, during process, by a button or whatever. It will freeze (though instead of garbled screen and error message, it just freezes at the splash screen if called on _ready)

Can you reproduce this in a GDScript project? This is probably not C#-related, but just to make sure.

I can also confirm this is not a C# issue, I have tried both C# and GDscript.

I am using EndeavourOS Linux, running Godot 4.0 RC3, project using the vulkan renderer, and my GPU is an AMD Radeon 5700XT if that information helps narrow down the issue.

Probably wise to open a new issue and reference this one anyways, if it's deemed superfluous then it's fine to close it later I guess.