Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointLight2D don't animate AnimatedTexture #67706

Closed
BurningBeard24 opened this issue Oct 21, 2022 · 3 comments
Closed

PointLight2D don't animate AnimatedTexture #67706

BurningBeard24 opened this issue Oct 21, 2022 · 3 comments

Comments

@BurningBeard24
Copy link

Godot version

Godot Engine v4.0.beta3.official.01ae26d31

System information

Xubuntu 22.04, Vulkan API 1.2.0 - Using Vulkan Device #0: NVIDIA - NVIDIA GeForce GTX 1060 6GB

Issue description

If I use a AnimatedTexture resource for a PointLight2D it only shows the first frame of the animation.
The same AnimatedTexture on a Sprite2D works.

Steps to reproduce

  1. create a AnimatedTexture
  2. set this AnimatedTexture as texture of a PointLight2D

Minimal reproduction project

No response

@Calinou
Copy link
Member

Calinou commented Oct 22, 2022

Related to #54506.

@clayjohn clayjohn added discussion and removed bug labels Oct 22, 2022
@clayjohn
Copy link
Member

I'm not sure supporting animated textures in PointLight2Ds is a good idea. In 4.0 2D lighting is done in a single pass which means that all light textures have to be copied to an atlas. Supporting animated textures would require either:

  1. updating the atlas every single frame by blitting the animated texture to it or,
  2. copying every frame of the animated texture into the atlas and then animating the rect of the PointLight2D.

Both options will be harmful for performance. I think number 2 may not be terrible, but I guess it depends on how big the AnimatedTexture is and how many frames it contains.

@AThousandShips
Copy link
Member

AThousandShips commented May 31, 2024

Closing in favor of:

Thank you for reporting

@AThousandShips AThousandShips closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants