Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon is empty after downloading from asset lib #81311

Closed
IceflowRE opened this issue Sep 4, 2023 · 3 comments · Fixed by #81358
Closed

Addon is empty after downloading from asset lib #81311

IceflowRE opened this issue Sep 4, 2023 · 3 comments · Fixed by #81358

Comments

@IceflowRE
Copy link
Contributor

IceflowRE commented Sep 4, 2023

Godot version

v4.1.1.stable.official [bd6af8e]

System information

Godot v4.1.1.stable - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1080 Ti (NVIDIA; 31.0.15.3667) - AMD Ryzen 9 7900X 12-Core Processor (24 Threads)

Issue description

This addon is shown as empty when downloaded via the editor. If downloading from the website everything works fine and there is content in the zip file.
image

The asset uses Custom as repository host, linking with URL to https://github.com/kenyoni-software/godot-addons/releases/download/hide_private_properties-1.0.1/hide_private_properties-1_0_1.zip

Steps to reproduce

Go to the Asset Lib and download Hide Private Properties.

Minimal reproduction project

N/A

@IceflowRE
Copy link
Contributor Author

Might be related #75712

@YuriSizov
Copy link
Contributor

Might be related #75712

Indeed, it's the same issue. Basically, we expect the ZIP to follow a certain structure which generated ZIPs do follow. It needs to have a root folder inside of it, which contains the actual contents. And your ZIP has its content at the top level instead. So the parser logic breaks.

I'm going to close this as a duplicate, but thanks for an example!

@YuriSizov YuriSizov closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2023
@YuriSizov
Copy link
Contributor

Actually, I've tested this a bit more, and the issue seems to be different. For your archive the our ZIP library cannot extract folders as individual records. It only extracts full paths to files in them. For ZIPs downloaded from GitHub, for example, folders are extracted as individual records, and it's done in order (so folders are guaranteed to be before the files in them).

I'm going to reopen this report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants